 Chromium Code Reviews
 Chromium Code Reviews Issue 2666873006:
  [Media Router] Convert to use typemaps for media_router.mojom.  (Closed)
    
  
    Issue 2666873006:
  [Media Router] Convert to use typemaps for media_router.mojom.  (Closed) 
  | Index: chrome/browser/media/router/media_route.h | 
| diff --git a/chrome/browser/media/router/media_route.h b/chrome/browser/media/router/media_route.h | 
| index e3aa5a3b6762ffd1bc8df463cc543e0931f18e00..aa83cc846fab98f8873c34e8299c0437bb3f055c 100644 | 
| --- a/chrome/browser/media/router/media_route.h | 
| +++ b/chrome/browser/media/router/media_route.h | 
| @@ -88,16 +88,36 @@ class MediaRoute { | 
| bool Equals(const MediaRoute& other) const; | 
| + // Used by Mojo. | 
| + MediaRoute(); | 
| + void set_media_route_id(const MediaRoute::Id& media_route_id) { | 
| + media_route_id_ = media_route_id; | 
| + } | 
| + void set_media_source(const MediaSource& media_source) { | 
| + media_source_ = media_source; | 
| + } | 
| + void set_media_sink_id(const MediaSink::Id& media_sink_id) { | 
| + media_sink_id_ = media_sink_id; | 
| + } | 
| + void set_description(const std::string& description) { | 
| + description_ = description; | 
| + } | 
| + void set_local(bool is_local) { is_local_ = is_local; } | 
| + void set_custom_controller_path(const std::string& custom_controller_path) { | 
| + custom_controller_path_ = custom_controller_path; | 
| + } | 
| + void set_for_display(bool for_display) { for_display_ = for_display; } | 
| + | 
| private: | 
| MediaRoute::Id media_route_id_; | 
| - MediaSource media_source_; | 
| + MediaSource media_source_ = MediaSource(MediaSource::Id()); | 
| 
dcheng
2017/02/01 22:51:08
Maybe just give MediaSource a default constructor
 
imcheng
2017/02/02 21:20:37
Done.
 | 
| MediaSink::Id media_sink_id_; | 
| std::string description_; | 
| - bool is_local_; | 
| + bool is_local_ = false; | 
| std::string custom_controller_path_; | 
| - bool for_display_; | 
| - bool is_incognito_; | 
| - bool is_offscreen_presentation_; | 
| + bool for_display_ = false; | 
| + bool is_incognito_ = false; | 
| + bool is_offscreen_presentation_ = false; | 
| }; | 
| } // namespace media_router |