Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 2666863002: [turbofan] Introduce ChangeTaggedToTaggedSigned operator. (Closed)

Created:
3 years, 10 months ago by Benedikt Meurer
Modified:
3 years, 10 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Introduce ChangeTaggedToTaggedSigned operator. We were missing a case for Tagged->TaggedSigned conversions when the input type is known to be Type::SignedSmall. BUG=chromium:687029 R=jarin@chromium.org Review-Url: https://codereview.chromium.org/2666863002 Cr-Commit-Position: refs/heads/master@{#42809} Committed: https://chromium.googlesource.com/v8/v8/+/68ae57ce1e220196b73b7c9c031756421291a24f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -3 lines) Patch
M src/compiler/effect-control-linearizer.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/effect-control-linearizer.cc View 2 chunks +24 lines, -0 lines 0 comments Download
M src/compiler/opcodes.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/representation-change.cc View 1 chunk +9 lines, -3 lines 0 comments Download
M src/compiler/simplified-operator.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/simplified-operator.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/verifier.cc View 1 chunk +2 lines, -0 lines 0 comments Download
A test/mjsunit/regress/regress-crbug-687029.js View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
Benedikt Meurer
3 years, 10 months ago (2017-01-31 08:28:53 UTC) #1
Jarin
lgtm, thanks!
3 years, 10 months ago (2017-01-31 08:33:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2666863002/1
3 years, 10 months ago (2017-01-31 08:47:29 UTC) #7
commit-bot: I haz the power
3 years, 10 months ago (2017-01-31 08:56:01 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/68ae57ce1e220196b73b7c9c03175642129...

Powered by Google App Engine
This is Rietveld 408576698