Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Issue 2666783007: [turbo] Rename CallFunction* JSOperators to Call*. (Closed)

Created:
3 years, 10 months ago by petermarshall
Modified:
3 years, 10 months ago
CC:
rmcilroy, v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbo] Rename CallFunction* JSOperators to Call*. Review-Url: https://codereview.chromium.org/2666783007 Cr-Commit-Position: refs/heads/master@{#42847} Committed: https://chromium.googlesource.com/v8/v8/+/cd85a88d78a2efef0d80e28187e7b9e81e7f2860

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+388 lines, -396 lines) Patch
M src/compiler/ast-graph-builder.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/ast-graph-builder.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/compiler/bytecode-graph-builder.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M src/compiler/js-builtin-reducer.cc View 3 chunks +6 lines, -7 lines 0 comments Download
M src/compiler/js-call-reducer.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/compiler/js-call-reducer.cc View 13 chunks +40 lines, -37 lines 0 comments Download
M src/compiler/js-generic-lowering.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M src/compiler/js-inlining.cc View 7 chunks +16 lines, -16 lines 0 comments Download
M src/compiler/js-inlining-heuristic.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/compiler/js-intrinsic-lowering.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/compiler/js-native-context-specialization.cc View 3 chunks +6 lines, -8 lines 0 comments Download
M src/compiler/js-operator.h View 5 chunks +21 lines, -27 lines 0 comments Download
M src/compiler/js-operator.cc View 3 chunks +33 lines, -35 lines 0 comments Download
M src/compiler/js-typed-lowering.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/js-typed-lowering.cc View 3 chunks +8 lines, -7 lines 0 comments Download
M src/compiler/opcodes.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/compiler/operator-properties.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/typer.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M src/compiler/verifier.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/unittests/compiler/js-builtin-reducer-unittest.cc View 74 chunks +222 lines, -222 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
petermarshall
PTAL =]
3 years, 10 months ago (2017-02-01 09:36:55 UTC) #4
Benedikt Meurer
Awesome, LGTM from me. Adding Michi.
3 years, 10 months ago (2017-02-01 09:43:44 UTC) #7
Michael Starzinger
LGTM. Nice, now it is much clearer that the call target of {JSCall} is not ...
3 years, 10 months ago (2017-02-01 10:34:46 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2666783007/1
3 years, 10 months ago (2017-02-01 10:43:14 UTC) #13
commit-bot: I haz the power
3 years, 10 months ago (2017-02-01 10:45:17 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/cd85a88d78a2efef0d80e28187e7b9e81e7...

Powered by Google App Engine
This is Rietveld 408576698