Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(663)

Issue 2666783006: [Merge M-56] Display "Not secure" verbose state for data: URLs (Closed)

Created:
3 years, 10 months ago by meacer
Modified:
3 years, 10 months ago
Reviewers:
estark
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

[Merge M-56] Display "Not secure" verbose state for data: URLs data: URLs don't define a secure context, and are a vector for spoofing. Display a "Not secure" badge for all data URLs, regardless of whether they show a password or credit card field. BUG=684811 TBR=estark NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2648353005 Cr-Commit-Position: refs/heads/master@{#446536} (cherry picked from commit effd1d519ff74fb1eb998e844f19d5079222b0fd) Review-Url: https://codereview.chromium.org/2666783006 Cr-Commit-Position: refs/branch-heads/2924@{#892} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} Committed: https://chromium.googlesource.com/chromium/src/+/2fde612bdca4930cd5bf82a2603ad86d9c5cec57

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -18 lines) Patch
M chrome/browser/ssl/security_state_tab_helper_browser_tests.cc View 1 chunk +22 lines, -0 lines 0 comments Download
M chrome/browser/ssl/ssl_browser_tests.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M components/security_state/core/security_state.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M components/security_state/core/security_state_unittest.cc View 10 chunks +26 lines, -13 lines 0 comments Download

Messages

Total messages: 8 (6 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2666783006/1
3 years, 10 months ago (2017-02-01 01:47:54 UTC) #4
commit-bot: I haz the power
3 years, 10 months ago (2017-02-01 01:55:29 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2fde612bdca4930cd5bf82a2603a...

Powered by Google App Engine
This is Rietveld 408576698