Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 2666763002: [wasm] Enable wasm imported memory tests on gc_stress (Closed)

Created:
3 years, 10 months ago by gdeepti
Modified:
3 years, 10 months ago
Reviewers:
bradnelson, ahaas
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Enable wasm imported memory tests on gc_stress Issues with instance wrapper allocation and JS Api errata have been fixed over the last few weeks, test in the bug no longer fails - enabling tests for imported memory. BUG=5683 R=bradnelson@chromium.org, ahaas@chromium.org Review-Url: https://codereview.chromium.org/2666763002 Cr-Commit-Position: refs/heads/master@{#42795} Committed: https://chromium.googlesource.com/v8/v8/+/3901e247b39e49b62c45904e816cb8ede2f32338

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M test/mjsunit/mjsunit.status View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
gdeepti
3 years, 10 months ago (2017-01-30 23:30:58 UTC) #5
bradnelson
lgtm
3 years, 10 months ago (2017-01-30 23:47:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2666763002/1
3 years, 10 months ago (2017-01-30 23:47:16 UTC) #8
commit-bot: I haz the power
3 years, 10 months ago (2017-01-30 23:48:58 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/3901e247b39e49b62c45904e816cb8ede2f...

Powered by Google App Engine
This is Rietveld 408576698