Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(564)

Issue 2666733002: Revert of Convert MediaRouter mojom apis to intake url::Origin objects instead of strings (Closed)

Created:
3 years, 10 months ago by imcheng
Modified:
3 years, 10 months ago
CC:
Aaron Boodman, abarth-chromium, chfremer+watch_chromium.org, chromium-reviews, darin (slow to review), feature-media-reviews_chromium.org, mcasas+watch+vc_chromium.org, media-router+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Convert MediaRouter mojom apis to intake url::Origin objects instead of strings (patchset #10 id:180001 of https://codereview.chromium.org/2627463003/ ) Reason for revert: This broke Media Router: 1) Missing dependency on url/mojo/origin.mojom in extension's context (see https://codereview.chromium.org/2665853002/ for fix) 2) media_router_bindings.js and the extension code were not converted to use Origin objects. Original issue's description: > Convert MediaRouter mojom apis to intake url::Origin objects instead of strings > > Currently, MediaRouter passes origins around as strings in the mojom api, and as GURLs at a higher level. This CL changes both the strings and the GURLs to be url::Origins instead. > > BUG=629374 > > Review-Url: https://codereview.chromium.org/2627463003 > Cr-Commit-Position: refs/heads/master@{#446868} > Committed: https://chromium.googlesource.com/chromium/src/+/588ccce1960c1ca47d65c75f5edb34e5e17d6deb TBR=mfoltz@chromium.org,dcheng@chromium.org,jdufault@chromium.org,wez@chromium.org,sky@chromium.org,steimel@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=629374, 686832, 686836

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+312 lines, -295 lines) Patch
M chrome/browser/media/android/router/media_router_android.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/media/android/router/media_router_android.cc View 7 chunks +23 lines, -9 lines 0 comments Download
M chrome/browser/media/android/router/media_router_dialog_controller_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media/router/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/media/router/create_presentation_connection_request.h View 2 chunks +4 lines, -7 lines 0 comments Download
M chrome/browser/media/router/create_presentation_connection_request.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/media/router/create_presentation_connection_request_unittest.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/media/router/media_router.h View 4 chunks +3 lines, -7 lines 0 comments Download
M chrome/browser/media/router/media_router_dialog_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media/router/media_sinks_observer.h View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/media/router/media_sinks_observer.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/media/router/media_sinks_observer_unittest.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/media/router/mock_media_router.h View 4 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/media/router/mojo/media_router.mojom View 5 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/media/router/mojo/media_router_mojo_impl.h View 6 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/media/router/mojo/media_router_mojo_impl.cc View 10 chunks +61 lines, -19 lines 0 comments Download
M chrome/browser/media/router/mojo/media_router_mojo_impl_unittest.cc View 27 chunks +68 lines, -87 lines 0 comments Download
M chrome/browser/media/router/mojo/media_router_mojo_test.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/media/router/presentation_media_sinks_observer.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media/router/presentation_media_sinks_observer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media/router/presentation_media_sinks_observer_unittest.cc View 2 chunks +1 line, -5 lines 0 comments Download
M chrome/browser/media/router/presentation_request.h View 4 chunks +7 lines, -5 lines 0 comments Download
M chrome/browser/media/router/presentation_request.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/media/router/presentation_request_unittest.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/media/router/presentation_service_delegate_impl.cc View 5 chunks +12 lines, -11 lines 0 comments Download
M chrome/browser/media/router/presentation_service_delegate_impl_unittest.cc View 5 chunks +6 lines, -7 lines 0 comments Download
M chrome/browser/media/router/test_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media/router/test_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/cast_config_client_media_router.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/system_tray_tray_cast_browsertest_media_router_chromeos.cc View 2 chunks +5 lines, -7 lines 0 comments Download
M chrome/browser/ui/webui/media_router/media_router_dialog_controller_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/media_router/media_router_ui.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/media_router/media_router_ui.cc View 8 chunks +10 lines, -11 lines 0 comments Download
M chrome/browser/ui/webui/media_router/media_router_ui_unittest.cc View 8 chunks +10 lines, -12 lines 0 comments Download
M chrome/browser/ui/webui/media_router/query_result_manager.h View 4 chunks +4 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/media_router/query_result_manager.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/media_router/query_result_manager_unittest.cc View 15 chunks +24 lines, -23 lines 0 comments Download
M chrome/test/media_router/media_router_e2e_browsertest.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/media_router/media_router_e2e_browsertest.cc View 5 chunks +7 lines, -6 lines 0 comments Download
M chrome/test/media_router/test_media_sinks_observer.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/media_router/test_media_sinks_observer.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
imcheng
Created Revert of Convert MediaRouter mojom apis to intake url::Origin objects instead of strings
3 years, 10 months ago (2017-01-30 21:26:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2666733002/1
3 years, 10 months ago (2017-01-30 21:27:22 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/144654) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 10 months ago (2017-01-30 21:30:44 UTC) #6
imcheng
3 years, 10 months ago (2017-01-30 21:47:04 UTC) #7
Created manual revert due to merge conflict:
https://codereview.chromium.org/2666743002/

closing this one.

Powered by Google App Engine
This is Rietveld 408576698