Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Side by Side Diff: chrome/browser/media/router/presentation_service_delegate_impl.cc

Issue 2666733002: Revert of Convert MediaRouter mojom apis to intake url::Origin objects instead of strings (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/media/router/presentation_service_delegate_impl.h" 5 #include "chrome/browser/media/router/presentation_service_delegate_impl.h"
6 6
7 #include <string> 7 #include <string>
8 #include <unordered_map> 8 #include <unordered_map>
9 #include <utility> 9 #include <utility>
10 #include <vector> 10 #include <vector>
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
53 53
54 // Returns the unique identifier for the supplied RenderFrameHost. 54 // Returns the unique identifier for the supplied RenderFrameHost.
55 RenderFrameHostId GetRenderFrameHostId(RenderFrameHost* render_frame_host) { 55 RenderFrameHostId GetRenderFrameHostId(RenderFrameHost* render_frame_host) {
56 int render_process_id = render_frame_host->GetProcess()->GetID(); 56 int render_process_id = render_frame_host->GetProcess()->GetID();
57 int render_frame_id = render_frame_host->GetRoutingID(); 57 int render_frame_id = render_frame_host->GetRoutingID();
58 return RenderFrameHostId(render_process_id, render_frame_id); 58 return RenderFrameHostId(render_process_id, render_frame_id);
59 } 59 }
60 60
61 // Gets the last committed URL for the render frame specified by 61 // Gets the last committed URL for the render frame specified by
62 // |render_frame_host_id|. 62 // |render_frame_host_id|.
63 url::Origin GetLastCommittedURLForFrame( 63 GURL GetLastCommittedURLForFrame(RenderFrameHostId render_frame_host_id) {
64 RenderFrameHostId render_frame_host_id) {
65 RenderFrameHost* render_frame_host = RenderFrameHost::FromID( 64 RenderFrameHost* render_frame_host = RenderFrameHost::FromID(
66 render_frame_host_id.first, render_frame_host_id.second); 65 render_frame_host_id.first, render_frame_host_id.second);
67 DCHECK(render_frame_host); 66 if (!render_frame_host)
68 return render_frame_host->GetLastCommittedOrigin(); 67 return GURL();
68
69 // TODO(crbug.com/632623): Use url::Origin in place of GURL for origins
70 return render_frame_host->GetLastCommittedOrigin().GetURL();
69 } 71 }
70 72
71 // Observes messages originating from the MediaSink connected to a MediaRoute 73 // Observes messages originating from the MediaSink connected to a MediaRoute
72 // that represents a presentation. Converts the messages into 74 // that represents a presentation. Converts the messages into
73 // content::PresentationSessionMessages and dispatches them via the provided 75 // content::PresentationSessionMessages and dispatches them via the provided
74 // PresentationSessionMessageCallback. 76 // PresentationSessionMessageCallback.
75 class PresentationSessionMessagesObserver : public RouteMessageObserver { 77 class PresentationSessionMessagesObserver : public RouteMessageObserver {
76 public: 78 public:
77 // |message_cb|: The callback to invoke whenever messages are received. 79 // |message_cb|: The callback to invoke whenever messages are received.
78 // |route_id|: ID of MediaRoute to listen for messages. 80 // |route_id|: ID of MediaRoute to listen for messages.
(...skipping 145 matching lines...) Expand 10 before | Expand all | Expand 10 after
224 226
225 bool PresentationFrame::SetScreenAvailabilityListener( 227 bool PresentationFrame::SetScreenAvailabilityListener(
226 content::PresentationScreenAvailabilityListener* listener) { 228 content::PresentationScreenAvailabilityListener* listener) {
227 MediaSource source(GetMediaSourceFromListener(listener)); 229 MediaSource source(GetMediaSourceFromListener(listener));
228 auto& sinks_observer = url_to_sinks_observer_[source.id()]; 230 auto& sinks_observer = url_to_sinks_observer_[source.id()];
229 if (sinks_observer && sinks_observer->listener() == listener) 231 if (sinks_observer && sinks_observer->listener() == listener)
230 return false; 232 return false;
231 233
232 sinks_observer.reset(new PresentationMediaSinksObserver( 234 sinks_observer.reset(new PresentationMediaSinksObserver(
233 router_, listener, source, 235 router_, listener, source,
234 GetLastCommittedURLForFrame(render_frame_host_id_))); 236 GetLastCommittedURLForFrame(render_frame_host_id_).GetOrigin()));
235 237
236 if (!sinks_observer->Init()) { 238 if (!sinks_observer->Init()) {
237 url_to_sinks_observer_.erase(source.id()); 239 url_to_sinks_observer_.erase(source.id());
238 listener->OnScreenAvailabilityNotSupported(); 240 listener->OnScreenAvailabilityNotSupported();
239 return false; 241 return false;
240 } 242 }
241 243
242 return true; 244 return true;
243 } 245 }
244 246
(...skipping 300 matching lines...) Expand 10 before | Expand all | Expand 10 after
545 const RenderFrameHostId& render_frame_host_id, 547 const RenderFrameHostId& render_frame_host_id,
546 const std::vector<GURL>& default_presentation_urls, 548 const std::vector<GURL>& default_presentation_urls,
547 const content::PresentationSessionStartedCallback& callback) { 549 const content::PresentationSessionStartedCallback& callback) {
548 if (!IsMainFrame(render_frame_host_id)) 550 if (!IsMainFrame(render_frame_host_id))
549 return; 551 return;
550 552
551 if (default_presentation_urls.empty()) { 553 if (default_presentation_urls.empty()) {
552 ClearDefaultPresentationRequest(); 554 ClearDefaultPresentationRequest();
553 } else { 555 } else {
554 DCHECK(!callback.is_null()); 556 DCHECK(!callback.is_null());
555 const auto& frame_origin = 557 GURL frame_url(GetLastCommittedURLForFrame(render_frame_host_id));
556 GetLastCommittedURLForFrame(render_frame_host_id);
557 PresentationRequest request(render_frame_host_id, default_presentation_urls, 558 PresentationRequest request(render_frame_host_id, default_presentation_urls,
558 frame_origin); 559 frame_url);
559 default_presentation_started_callback_ = callback; 560 default_presentation_started_callback_ = callback;
560 SetDefaultPresentationRequest(request); 561 SetDefaultPresentationRequest(request);
561 } 562 }
562 } 563 }
563 564
564 void PresentationFrameManager::AddDefaultPresentationRequestObserver( 565 void PresentationFrameManager::AddDefaultPresentationRequestObserver(
565 PresentationServiceDelegateImpl::DefaultPresentationRequestObserver* 566 PresentationServiceDelegateImpl::DefaultPresentationRequestObserver*
566 observer) { 567 observer) {
567 default_presentation_request_observers_.AddObserver(observer); 568 default_presentation_request_observers_.AddObserver(observer);
568 } 569 }
(...skipping 230 matching lines...) Expand 10 before | Expand all | Expand 10 after
799 const content::PresentationSessionStartedCallback& success_cb, 800 const content::PresentationSessionStartedCallback& success_cb,
800 const content::PresentationSessionErrorCallback& error_cb) { 801 const content::PresentationSessionErrorCallback& error_cb) {
801 DVLOG(2) << "PresentationServiceDelegateImpl::JoinSession"; 802 DVLOG(2) << "PresentationServiceDelegateImpl::JoinSession";
802 if (presentation_urls.empty()) { 803 if (presentation_urls.empty()) {
803 error_cb.Run(content::PresentationError( 804 error_cb.Run(content::PresentationError(
804 content::PRESENTATION_ERROR_NO_PRESENTATION_FOUND, 805 content::PRESENTATION_ERROR_NO_PRESENTATION_FOUND,
805 "Invalid presentation arguments.")); 806 "Invalid presentation arguments."));
806 return; 807 return;
807 } 808 }
808 809
809 const url::Origin& origin = GetLastCommittedURLForFrame( 810 const url::Origin& origin = url::Origin(GetLastCommittedURLForFrame(
810 RenderFrameHostId(render_process_id, render_frame_id)); 811 RenderFrameHostId(render_process_id, render_frame_id)));
811 812
812 #if !defined(OS_ANDROID) 813 #if !defined(OS_ANDROID)
813 if (IsAutoJoinPresentationId(presentation_id) && 814 if (IsAutoJoinPresentationId(presentation_id) &&
814 ShouldCancelAutoJoinForOrigin(origin)) { 815 ShouldCancelAutoJoinForOrigin(origin)) {
815 error_cb.Run(content::PresentationError( 816 error_cb.Run(content::PresentationError(
816 content::PRESENTATION_ERROR_SESSION_REQUEST_CANCELLED, 817 content::PRESENTATION_ERROR_SESSION_REQUEST_CANCELLED,
817 "Auto-join request cancelled by user preferences.")); 818 "Auto-join request cancelled by user preferences."));
818 return; 819 return;
819 } 820 }
820 #endif // !defined(OS_ANDROID) 821 #endif // !defined(OS_ANDROID)
821 822
822 // TODO(crbug.com/627655): Handle multiple URLs. 823 // TODO(crbug.com/627655): Handle multiple URLs.
823 const GURL& presentation_url = presentation_urls[0]; 824 const GURL& presentation_url = presentation_urls[0];
824 bool incognito = web_contents_->GetBrowserContext()->IsOffTheRecord(); 825 bool incognito = web_contents_->GetBrowserContext()->IsOffTheRecord();
825 std::vector<MediaRouteResponseCallback> route_response_callbacks; 826 std::vector<MediaRouteResponseCallback> route_response_callbacks;
826 route_response_callbacks.push_back( 827 route_response_callbacks.push_back(
827 base::Bind(&PresentationServiceDelegateImpl::OnJoinRouteResponse, 828 base::Bind(&PresentationServiceDelegateImpl::OnJoinRouteResponse,
828 weak_factory_.GetWeakPtr(), render_process_id, render_frame_id, 829 weak_factory_.GetWeakPtr(), render_process_id, render_frame_id,
829 presentation_url, presentation_id, success_cb, error_cb)); 830 presentation_url, presentation_id, success_cb, error_cb));
830 router_->JoinRoute(MediaSourceForPresentationUrl(presentation_url).id(), 831 router_->JoinRoute(MediaSourceForPresentationUrl(presentation_url).id(),
831 presentation_id, origin, web_contents_, 832 presentation_id, origin.GetURL(), web_contents_,
832 route_response_callbacks, base::TimeDelta(), incognito); 833 route_response_callbacks, base::TimeDelta(), incognito);
833 } 834 }
834 835
835 void PresentationServiceDelegateImpl::CloseConnection( 836 void PresentationServiceDelegateImpl::CloseConnection(
836 int render_process_id, 837 int render_process_id,
837 int render_frame_id, 838 int render_frame_id,
838 const std::string& presentation_id) { 839 const std::string& presentation_id) {
839 const RenderFrameHostId rfh_id(render_process_id, render_frame_id); 840 const RenderFrameHostId rfh_id(render_process_id, render_frame_id);
840 const MediaRoute::Id& route_id = 841 const MediaRoute::Id& route_id =
841 frame_manager_->GetRouteId(rfh_id, presentation_id); 842 frame_manager_->GetRouteId(rfh_id, presentation_id);
(...skipping 145 matching lines...) Expand 10 before | Expand all | Expand 10 after
987 const base::ListValue* origins = 988 const base::ListValue* origins =
988 Profile::FromBrowserContext(web_contents_->GetBrowserContext()) 989 Profile::FromBrowserContext(web_contents_->GetBrowserContext())
989 ->GetPrefs() 990 ->GetPrefs()
990 ->GetList(prefs::kMediaRouterTabMirroringSources); 991 ->GetList(prefs::kMediaRouterTabMirroringSources);
991 return origins && 992 return origins &&
992 origins->Find(base::StringValue(origin.Serialize())) != origins->end(); 993 origins->Find(base::StringValue(origin.Serialize())) != origins->end();
993 } 994 }
994 #endif // !defined(OS_ANDROID) 995 #endif // !defined(OS_ANDROID)
995 996
996 } // namespace media_router 997 } // namespace media_router
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698