Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Issue 2666723002: Fix testing threshold of realtimeanalyser-freq-data.html (Closed)

Created:
3 years, 10 months ago by hongchan
Modified:
3 years, 10 months ago
Reviewers:
Raymond Toy
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix testing threshold of realtimeanalyser-freq-data.html On macOS Sierra (10.12.2), this realtime analyser test started to fail. This CL updates the threshold of the test to make it pass. It seems that the macOS's internal FFT has been changed. BUG=679036 TEST= realtimeanalyser-freq-data.html is now passing on macOS 10.12.2. Review-Url: https://codereview.chromium.org/2666723002 Cr-Commit-Position: refs/heads/master@{#447087} Committed: https://chromium.googlesource.com/chromium/src/+/02c6e524dcdbc0a75e432d5a739a2200cdad9aba

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/LayoutTests/webaudio/Analyser/realtimeanalyser-freq-data.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
hongchan
PTAL.
3 years, 10 months ago (2017-01-30 20:56:37 UTC) #2
Raymond Toy
On 2017/01/30 20:56:37, hongchan wrote: > PTAL. lgtm, but fix the description by removing the ...
3 years, 10 months ago (2017-01-30 21:06:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2666723002/1
3 years, 10 months ago (2017-01-30 21:11:25 UTC) #6
commit-bot: I haz the power
3 years, 10 months ago (2017-01-30 22:11:46 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/02c6e524dcdbc0a75e432d5a739a...

Powered by Google App Engine
This is Rietveld 408576698