Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2666713002: [WebRTC] Copy HttpAuthCache from main request context into webrtc context (Closed)

Created:
3 years, 10 months ago by asanka
Modified:
3 years, 10 months ago
Reviewers:
Sergey Ulanov, cfredric
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[WebRTC] Copy HttpAuthCache from main request context into webrtc context WebRTC uses ProxyResolvingClientSocket to tunnel through proxies. The socket creates a new request context using a provided request context as a base. This CL changes this logic to copy the HttpAuthCache from the original request context to the next context so that proxies that require explict credentials can be used. Based on https://codereview.chromium.org/2552403002 by cfredric. R=sergeyu@chromium.org BUG=439560 Review-Url: https://codereview.chromium.org/2666713002 Cr-Commit-Position: refs/heads/master@{#447091} Committed: https://chromium.googlesource.com/chromium/src/+/77ec64724b4718f600f0e36d1ab31a6f6b00656d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+152 lines, -0 lines) Patch
M jingle/glue/proxy_resolving_client_socket.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M jingle/glue/proxy_resolving_client_socket_unittest.cc View 2 chunks +144 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
asanka
PTAL?
3 years, 10 months ago (2017-01-30 20:59:05 UTC) #3
Sergey Ulanov
lgtm
3 years, 10 months ago (2017-01-30 22:23:51 UTC) #7
asanka
On 2017/01/30 at 22:23:51, sergeyu wrote: > lgtm Thanks!
3 years, 10 months ago (2017-01-30 22:24:52 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2666713002/1
3 years, 10 months ago (2017-01-30 22:25:47 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-01-30 22:31:24 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/77ec64724b4718f600f0e36d1ab3...

Powered by Google App Engine
This is Rietveld 408576698