Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 2666543004: Merged: [runtime] Fix Array.prototype.concat with complex @@species (Closed)

Created:
3 years, 10 months ago by Camillo Bruni
Modified:
3 years, 10 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com, v8-merges_googlegroups.com, ulan
Target Ref:
refs/pending/branch-heads/5.6
Project:
v8
Visibility:
Public.

Description

Merged: [runtime] Fix Array.prototype.concat with complex @@species Revision: e5608155aeb18a76fdb495d446efe1f9e33e749b BUG=682194 LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true R=jkummerow@chromium.org Review-Url: https://codereview.chromium.org/2666543004 . Cr-Commit-Position: refs/branch-heads/5.6@{#92} Cr-Branched-From: bdd3886218dfe76e8560eb8a18401942452ae859-refs/heads/5.6.326@{#1} Cr-Branched-From: 879f6599eee6e1dfcbe9a24bf688b261c03e9558-refs/heads/master@{#41014} Committed: https://chromium.googlesource.com/v8/v8/+/8b0e98df72e727f29cd4f67a67492b3fd4c2fa2e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -8 lines) Patch
M src/builtins/builtins-array.cc View 7 chunks +18 lines, -8 lines 0 comments Download
A test/mjsunit/regress/regress-crbug-682194.js View 1 chunk +35 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Camillo Bruni
3 years, 10 months ago (2017-01-30 18:28:43 UTC) #1
Camillo Bruni
NOTE: This script will no longer automatically update include/v8-version.h and create a tag. This is ...
3 years, 10 months ago (2017-01-30 18:28:45 UTC) #2
Jakob Kummerow
lgtm
3 years, 10 months ago (2017-01-30 18:30:25 UTC) #3
Camillo Bruni
3 years, 10 months ago (2017-01-30 18:33:23 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8b0e98df72e727f29cd4f67a67492b3fd4c2fa2e.

Powered by Google App Engine
This is Rietveld 408576698