Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 2666543002: [turbofan] Optimize ReferenceEqual based on input types. (Closed)

Created:
3 years, 10 months ago by Benedikt Meurer
Modified:
3 years, 10 months ago
Reviewers:
petermarshall
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Optimize ReferenceEqual based on input types. We can constant-fold ReferenceEqual(a,b) to false, if the intersection of the types of a and b is empty. This also repairs a regression in the RestParameter performance test. R=petermarshall@chromium.org BUG=chromium:686668 Review-Url: https://codereview.chromium.org/2666543002 Cr-Commit-Position: refs/heads/master@{#42775} Committed: https://chromium.googlesource.com/v8/v8/+/0b1b8c77a040a4379192a3168c97b4ce4645d54f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M src/compiler/typed-optimization.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/typed-optimization.cc View 2 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Benedikt Meurer
3 years, 10 months ago (2017-01-30 12:12:02 UTC) #1
petermarshall
LGTM! Thanks
3 years, 10 months ago (2017-01-30 12:20:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2666543002/1
3 years, 10 months ago (2017-01-30 13:12:43 UTC) #8
commit-bot: I haz the power
3 years, 10 months ago (2017-01-30 13:14:45 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/0b1b8c77a040a4379192a3168c97b4ce464...

Powered by Google App Engine
This is Rietveld 408576698