Changed ETableLayout to an enum class and renamed its members

Changed ETableLayout to an enum class and renamed its members

Changed ETableLayout to an enum class and gave it an unsigned underlying
type. Also renamed its members to match the CSS keywords they
represent, and added the 'k' prefix in line with the Blink rename to
match Chromium style.

Changing it to an enum class enforces better namespacing and code
practices. Adding the unsigned underlying type is pre-work for when the
class is eventually stored as an enum bitfield (it would be done in this
patch, except a presubmit warning already exists that prevents that. The
presubmit warning needs to be updated before that change can occur.)

This is also pre-work to allow ETableLayout to be used by generated
fields in ComputedStyleBase.

BUG=684966
Review-Url: https://codereview.chromium.org/2666483002
Cr-Commit-Position: refs/heads/master@{#447121}
Committed: https://chromium.googlesource.com/chromium/src/+/581521281404da94a7c8a6281d34c7ac65fa1d9d

[shend, 2017-01-30 00:52:05]

shend@chromium.org changed reviewers:
+ bugsnash@chromium.org

[shend, 2017-01-30 00:52:06]

Hey Bugs PTAL, more renames :P

[shend, 2017-01-30 06:56:52]

The CQ bit was checked by shend@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-30 06:57:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-30 08:56:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-30 08:56:55]

Dry run: This issue passed the CQ dry run.

[Bugs Nash, 2017-01-30 19:33:24]

lgtm

[shend, 2017-01-30 21:35:43]

shend@chromium.org changed reviewers:
+ sashab@chromium.org

[shend, 2017-01-30 21:35:43]

Sasha, PTAL :)

[sashab, 2017-01-30 23:43:38]

Haha wow this is barely used! LGTM

[shend, 2017-01-31 00:03:57]

The CQ bit was checked by shend@chromium.org

[commit-bot: I haz the power, 2017-01-31 00:04:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-31 00:11:57]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1485821037164490,
"parent_rev": "f7e63f8e6d069b9743ca2ac344f52f059295c776", "commit_rev":
"581521281404da94a7c8a6281d34c7ac65fa1d9d"}

[commit-bot: I haz the power, 2017-01-31 00:12:32]

Description was changed from

==========
Changed ETableLayout to an enum class and renamed its members

Changed ETableLayout to an enum class and gave it an unsigned underlying
type. Also renamed its members to match the CSS keywords they
represent, and added the 'k' prefix in line with the Blink rename to
match Chromium style.

Changing it to an enum class enforces better namespacing and code
practices. Adding the unsigned underlying type is pre-work for when the
class is eventually stored as an enum bitfield (it would be done in this
patch, except a presubmit warning already exists that prevents that. The
presubmit warning needs to be updated before that change can occur.)

This is also pre-work to allow ETableLayout to be used by generated
fields in ComputedStyleBase.

BUG=684966
==========

to

==========
Changed ETableLayout to an enum class and renamed its members

Changed ETableLayout to an enum class and gave it an unsigned underlying
type. Also renamed its members to match the CSS keywords they
represent, and added the 'k' prefix in line with the Blink rename to
match Chromium style.

Changing it to an enum class enforces better namespacing and code
practices. Adding the unsigned underlying type is pre-work for when the
class is eventually stored as an enum bitfield (it would be done in this
patch, except a presubmit warning already exists that prevents that. The
presubmit warning needs to be updated before that change can occur.)

This is also pre-work to allow ETableLayout to be used by generated
fields in ComputedStyleBase.

BUG=684966

Review-Url: https://codereview.chromium.org/2666483002
Cr-Commit-Position: refs/heads/master@{#447121}
Committed:
https://chromium.googlesource.com/chromium/src/+/581521281404da94a7c8a6281d34...
==========

[commit-bot: I haz the power, 2017-01-31 00:12:33]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/581521281404da94a7c8a6281d34...