Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2666413002:
Fix opacity getting stuck when clicking on a new window while it's being created (Closed)
DescriptionFix opacity getting stuck when clicking on a new window while it's being created
While the window is being created, it's going through an opacity animation. Clicking
on the window's title bar at this point, starts a drag. We must store the target
opacity (rather than the current one) to be able to set it on drag completion, otherwise
the window opacity will be stuck to its value at the time of the click.
BUG=687003
Review-Url: https://codereview.chromium.org/2666413002
Cr-Commit-Position: refs/heads/master@{#448352}
Committed: https://chromium.googlesource.com/chromium/src/+/1b08650cd63cbd6fa11cc5a840d716a3b945306b
Patch Set 1 #Patch Set 2 : Adding more info #
Total comments: 1
Messages
Total messages: 20 (13 generated)
The CQ bit was checked by afakhry@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
afakhry@chromium.org changed reviewers: + jamescook@chromium.org
James, can you please take a look? Thanks!
Can you add a comment to either the CL description or the code explaining what the problem was and why this fixes it? The code looks fine but it's hard for me to figure out why the old way was broken.
Description was changed from ========== Fix opacity getting stuck when clicking on a new window while it's being created BUG=687003 ========== to ========== Fix opacity getting stuck when clicking on a new window while it's being created While the window is being created, it's going through an opacity animation. Clicking on the window's title bar at this point, starts a drag. We must store the target opacity (rather than the current one) to be able to set it on drag completion, otherwise the window opacity will be stuck to its value at the time of the click. BUG=687003 ==========
The CQ bit was checked by afakhry@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Done. Sorry, I created this CL initially as a proposal to be tested by reveman.
Nice docs. LGTM
The CQ bit was unchecked by afakhry@chromium.org
The CQ bit was checked by afakhry@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1486408003830130,
"parent_rev": "be523b7cc0438b8bb9629c5863e1959a1e9fa272", "commit_rev":
"1b08650cd63cbd6fa11cc5a840d716a3b945306b"}
Message was sent while issue was closed.
Description was changed from ========== Fix opacity getting stuck when clicking on a new window while it's being created While the window is being created, it's going through an opacity animation. Clicking on the window's title bar at this point, starts a drag. We must store the target opacity (rather than the current one) to be able to set it on drag completion, otherwise the window opacity will be stuck to its value at the time of the click. BUG=687003 ========== to ========== Fix opacity getting stuck when clicking on a new window while it's being created While the window is being created, it's going through an opacity animation. Clicking on the window's title bar at this point, starts a drag. We must store the target opacity (rather than the current one) to be able to set it on drag completion, otherwise the window opacity will be stuck to its value at the time of the click. BUG=687003 Review-Url: https://codereview.chromium.org/2666413002 Cr-Commit-Position: refs/heads/master@{#448352} Committed: https://chromium.googlesource.com/chromium/src/+/1b08650cd63cbd6fa11cc5a840d7... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/1b08650cd63cbd6fa11cc5a840d7...
Message was sent while issue was closed.
sky@chromium.org changed reviewers: + sky@chromium.org
Message was sent while issue was closed.
https://codereview.chromium.org/2666413002/diff/20001/ash/common/wm/drag_deta... File ash/common/wm/drag_details.cc (right): https://codereview.chromium.org/2666413002/diff/20001/ash/common/wm/drag_deta... ash/common/wm/drag_details.cc:56: initial_opacity(window->GetLayer()->GetTargetOpacity()), This is subtle. I would be nice to have test coverage. |
