mash: Exit main process if ui service crashes

mash: Exit main process if ui service crashes

Both sides of a connection to the ui service cache information about the
other side. For now, rather than trying to make the ui service restartable
we just bring down the main chrome --mash process if it crashes. The
Chrome OS session_manager will then restart everything.

Add logging for when the main process exits due to a critical service crash.

BUG=678683
TEST=kill -SIGILL <ui-service-pid>, main chrome process exits

Review-Url: https://codereview.chromium.org/2666383002
Cr-Commit-Position: refs/heads/master@{#447635}
Committed: https://chromium.googlesource.com/chromium/src/+/3e0797f2ae6a7d349acf6aaf8d02215f28c559c1

[James Cook, 2017-02-01 18:19:53]

jamescook@chromium.org changed reviewers:
+ rockot@chromium.org

[James Cook, 2017-02-01 18:19:54]

rockot, please take a look.

https://codereview.chromium.org/2666383002/diff/1/chrome/app/mash/mash_runner.cc
File chrome/app/mash/mash_runner.cc (left):

https://codereview.chromium.org/2666383002/diff/1/chrome/app/mash/mash_runner...
chrome/app/mash/mash_runner.cc:162: if (!run_loop->running())
This wasn't needed. RunLoop::Quit() is a no-op if the loop isn't running.

[Ken Rockot(use gerrit already), 2017-02-01 21:13:55]

lgtm

https://codereview.chromium.org/2666383002/diff/1/chrome/app/mash/mash_runner.cc
File chrome/app/mash/mash_runner.cc (left):

https://codereview.chromium.org/2666383002/diff/1/chrome/app/mash/mash_runner...
chrome/app/mash/mash_runner.cc:162: if (!run_loop->running())
On 2017/02/01 at 18:19:54, James Cook wrote:
> This wasn't needed. RunLoop::Quit() is a no-op if the loop isn't running.

Ah right, missed this. In fact, it's also not possible (AFAICT) for this to be
false since the function is only ever invoked as a task on the loop, and tasks
are never run while !running(). I think?

[James Cook, 2017-02-01 21:26:51]

Thanks for the review.

https://codereview.chromium.org/2666383002/diff/1/chrome/app/mash/mash_runner.cc
File chrome/app/mash/mash_runner.cc (left):

https://codereview.chromium.org/2666383002/diff/1/chrome/app/mash/mash_runner...
chrome/app/mash/mash_runner.cc:162: if (!run_loop->running())
On 2017/02/01 21:13:55, Ken Rockot wrote:
> On 2017/02/01 at 18:19:54, James Cook wrote:
> > This wasn't needed. RunLoop::Quit() is a no-op if the loop isn't running.
> 
> Ah right, missed this. In fact, it's also not possible (AFAICT) for this to be
> false since the function is only ever invoked as a task on the loop, and tasks
> are never run while !running(). I think?

Acknowledged.

[James Cook, 2017-02-01 21:26:55]

The CQ bit was checked by jamescook@chromium.org

[commit-bot: I haz the power, 2017-02-01 21:27:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-01 23:07:08]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1485984415509800, "parent_rev":
"dbe6848664fd910b6d924f2a0f59ea5fd311653d", "commit_rev":
"3e0797f2ae6a7d349acf6aaf8d02215f28c559c1"}

[commit-bot: I haz the power, 2017-02-01 23:07:45]

Description was changed from

==========
mash: Exit main process if ui service crashes

Both sides of a connection to the ui service cache information about the
other side. For now, rather than trying to make the ui service restartable
we just bring down the main chrome --mash process if it crashes. The
Chrome OS session_manager will then restart everything.

Add logging for when the main process exits due to a critical service crash.

BUG=678683
TEST=kill -SIGILL <ui-service-pid>, main chrome process exits
==========

to

==========
mash: Exit main process if ui service crashes

Both sides of a connection to the ui service cache information about the
other side. For now, rather than trying to make the ui service restartable
we just bring down the main chrome --mash process if it crashes. The
Chrome OS session_manager will then restart everything.

Add logging for when the main process exits due to a critical service crash.

BUG=678683
TEST=kill -SIGILL <ui-service-pid>, main chrome process exits

Review-Url: https://codereview.chromium.org/2666383002
Cr-Commit-Position: refs/heads/master@{#447635}
Committed:
https://chromium.googlesource.com/chromium/src/+/3e0797f2ae6a7d349acf6aaf8d02...
==========

[commit-bot: I haz the power, 2017-02-01 23:07:45]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3e0797f2ae6a7d349acf6aaf8d02...