Merge ConstantInstr -> UnboxDouble to UnboxedConstant. Reduces register usage and allows for variou…

runtime/vm/assembler_x64.cc

Index: runtime/vm/assembler_x64.cc
===================================================================
--- runtime/vm/assembler_x64.cc	(revision 35632)
+++ runtime/vm/assembler_x64.cc	(working copy)
@@ -2567,6 +2567,12 @@
 }
 
 
+void Assembler::LoadDoubleConstant(XmmRegister dst, double value, Register pp) {
+  const int32_t offset = FindImmediate(*reinterpret_cast<int64_t*>(&value));

[zra, 2014/05/01 20:41:19]

See checks in CanLoadImmediateFromPool and the fixup for the low bit in
LaodImmediate. I think the same are needed here.

[srdjan, 2014/05/01 21:14:13]

Yes, removed, on ARM do it as previous without using the address.

+  movsd(dst, Address::AddressBaseImm32(pp, offset));
+}
+
+
 intptr_t Assembler::FindImmediate(int64_t imm) {
   ASSERT(Isolate::Current() != Dart::vm_isolate());
   ASSERT(!object_pool_.IsNull());