Merge ConstantInstr -> UnboxDouble to UnboxedConstant. Reduces register usage and allows for variou…

runtime/vm/assembler_x64.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"
 #if defined(TARGET_ARCH_X64)
 
 #include "vm/assembler.h"
 #include "vm/cpu.h"
 #include "vm/heap.h"
@@ skipping 2549 matching lines @@
     const int32_t offset =
         Array::element_offset(FindObject(object, kNotPatchable));
     cmpq(reg, Address(pp, offset-kHeapObjectTag));
   } else {
     CompareImmediate(
         reg, Immediate(reinterpret_cast<int64_t>(object.raw())), pp);
   }
 }
 
 
+void Assembler::LoadDoubleConstant(XmmRegister dst, double value, Register pp) {
+  const int32_t offset = FindImmediate(*reinterpret_cast<int64_t*>(&value));

[zra, 2014/05/01 20:41:19]

See checks in CanLoadImmediateFromPool and the fixup for the low bit in
LaodImmediate. I think the same are needed here.

[srdjan, 2014/05/01 21:14:13]

Yes, removed, on ARM do it as previous without using the address.

+  movsd(dst, Address::AddressBaseImm32(pp, offset));
+}
+
+
 intptr_t Assembler::FindImmediate(int64_t imm) {
   ASSERT(Isolate::Current() != Dart::vm_isolate());
   ASSERT(!object_pool_.IsNull());
   const Smi& smi = Smi::Handle(reinterpret_cast<RawSmi*>(imm));
   return FindObject(smi, kNotPatchable);
 }
 
 
 bool Assembler::CanLoadImmediateFromPool(const Immediate& imm, Register pp) {
   return !imm.is_int32() &&
@@ skipping 688 matching lines @@
 
 
 const char* Assembler::FpuRegisterName(FpuRegister reg) {
   ASSERT((0 <= reg) && (reg < kNumberOfXmmRegisters));
   return xmm_reg_names[reg];
 }
 
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_X64