Merge ConstantInstr -> UnboxDouble to UnboxedConstant. Reduces register usage and allows for variou…

runtime/vm/flow_graph_compiler_arm.cc

Index: runtime/vm/flow_graph_compiler_arm.cc
===================================================================
--- runtime/vm/flow_graph_compiler_arm.cc	(revision 35632)
+++ runtime/vm/flow_graph_compiler_arm.cc	(working copy)
@@ -1635,6 +1635,10 @@
     if (destination.IsRegister()) {
       const Object& constant = source.constant();
       __ LoadObject(destination.reg(), constant);
+    } else if (destination.IsFpuRegister()) {
+      const Double& constant = Double::Cast(source.constant());
+      DRegister dst = EvenDRegisterOf(destination.fpu_reg());
+      __ LoadDImmediate(dst, constant.value(), TMP);

[zra, 2014/05/01 18:34:14]

Can't use TMP here.

[srdjan, 2014/05/01 20:33:04]

Fixed:
      const DRegister dst = EvenDRegisterOf(destination.fpu_reg());
      __ LoadObject(TMP, constant);
      __ AddImmediate(TMP, TMP, Double::value_offset() - kHeapObjectTag);
      __ vldrd(dst, Address(TMP, 0));

     } else {
       ASSERT(destination.IsStackSlot());
       const intptr_t dest_offset = destination.ToStackSlotOffset();