Merge ConstantInstr -> UnboxDouble to UnboxedConstant. Reduces register usage and allows for variou…

runtime/vm/flow_graph_compiler_arm.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"  // Needed here to get TARGET_ARCH_ARM.
 #if defined(TARGET_ARCH_ARM)
 
 #include "vm/flow_graph_compiler.h"
 
 #include "vm/ast_printer.h"
@@ skipping 1617 matching lines @@
       const intptr_t dest_offset = destination.ToStackSlotOffset();
       const DRegister dtmp0 = DTMP;
       __ LoadMultipleDFromOffset(dtmp0, 2, FP, source_offset);
       __ StoreMultipleDToOffset(dtmp0, 2, FP, dest_offset);
     }
   } else {
     ASSERT(source.IsConstant());
     if (destination.IsRegister()) {
       const Object& constant = source.constant();
       __ LoadObject(destination.reg(), constant);
+    } else if (destination.IsFpuRegister()) {
+      const Double& constant = Double::Cast(source.constant());
+      DRegister dst = EvenDRegisterOf(destination.fpu_reg());
+      __ LoadDImmediate(dst, constant.value(), TMP);

[zra, 2014/05/01 18:34:14]

Can't use TMP here.

[srdjan, 2014/05/01 20:33:04]

Fixed:
      const DRegister dst = EvenDRegisterOf(destination.fpu_reg());
      __ LoadObject(TMP, constant);
      __ AddImmediate(TMP, TMP, Double::value_offset() - kHeapObjectTag);
      __ vldrd(dst, Address(TMP, 0));

     } else {
       ASSERT(destination.IsStackSlot());
       const intptr_t dest_offset = destination.ToStackSlotOffset();
       __ LoadObject(TMP, source.constant());
       __ StoreToOffset(kWord, TMP, FP, dest_offset);
     }
   }
 
   move->Eliminate();
 }
@@ skipping 141 matching lines @@
   DRegister dreg = EvenDRegisterOf(reg);
   __ vldrd(dreg, Address(SP, kDoubleSize, Address::PostIndex));
 }
 
 
 #undef __
 
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_ARM