Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 2666323002: [turbofan] Account for all initialized BinaryOp/CompareIC slots. (Closed)

Created:
3 years, 10 months ago by Benedikt Meurer
Modified:
3 years, 10 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Account for all initialized BinaryOp/CompareIC slots. When computing the type info for a given function, make sure to also count generic BinaryOp and Compare IC slots. TurboFan can deal with those, and often still generates good code. R=jarin@chromium.org Review-Url: https://codereview.chromium.org/2666323002 Cr-Commit-Position: refs/heads/master@{#42992} Committed: https://chromium.googlesource.com/v8/v8/+/47f858d217eebf3b498458efe550a1b19ec773bd

Patch Set 1 #

Patch Set 2 : REBASE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M src/type-feedback-vector-inl.h View 1 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (13 generated)
Benedikt Meurer
3 years, 10 months ago (2017-02-01 12:29:59 UTC) #1
Jarin
lgtm
3 years, 10 months ago (2017-02-03 13:49:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2666323002/1
3 years, 10 months ago (2017-02-03 13:52:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2666323002/20001
3 years, 10 months ago (2017-02-07 12:04:37 UTC) #15
commit-bot: I haz the power
3 years, 10 months ago (2017-02-07 12:31:17 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/47f858d217eebf3b498458efe550a1b19ec...

Powered by Google App Engine
This is Rietveld 408576698