Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 2666273003: Enable VP9 support in WebRTC HW encoder and decoders (Closed)

Created:
3 years, 10 months ago by emircan
Modified:
3 years, 10 months ago
Reviewers:
Pawel Osciak, chfremer
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable VP9 support in WebRTC HW encoder and decoders BUG=687650 TEST=Tested on Win laptops(Asus Strix and Lenovo P50) but they do not have support for VP9 decode. VPX encode is tested with the patch on https://codereview.chromium.org/2668293002/. Review-Url: https://codereview.chromium.org/2666273003 Cr-Commit-Position: refs/heads/master@{#447629} Committed: https://chromium.googlesource.com/chromium/src/+/33a70a137b5635e13d60c66d3666d7f6167fe831

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M content/renderer/media/gpu/rtc_video_decoder.cc View 1 chunk +3 lines, -0 lines 2 comments Download
M content/renderer/media/gpu/rtc_video_encoder.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (12 generated)
emircan
PTAL.
3 years, 10 months ago (2017-02-01 19:44:09 UTC) #5
chfremer
lgtm
3 years, 10 months ago (2017-02-01 22:45:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2666273003/1
3 years, 10 months ago (2017-02-01 22:46:30 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/33a70a137b5635e13d60c66d3666d7f6167fe831
3 years, 10 months ago (2017-02-01 22:57:43 UTC) #15
Pawel Osciak
https://codereview.chromium.org/2666273003/diff/1/content/renderer/media/gpu/rtc_video_decoder.cc File content/renderer/media/gpu/rtc_video_decoder.cc (right): https://codereview.chromium.org/2666273003/diff/1/content/renderer/media/gpu/rtc_video_decoder.cc#newcode114 content/renderer/media/gpu/rtc_video_decoder.cc:114: profile = media::VP9PROFILE_MIN; Would VP9PROFILE_PROFILE0 be better here perhaps?
3 years, 10 months ago (2017-02-02 00:48:13 UTC) #17
emircan
3 years, 10 months ago (2017-02-03 18:11:30 UTC) #18
Message was sent while issue was closed.
https://codereview.chromium.org/2666273003/diff/1/content/renderer/media/gpu/...
File content/renderer/media/gpu/rtc_video_decoder.cc (right):

https://codereview.chromium.org/2666273003/diff/1/content/renderer/media/gpu/...
content/renderer/media/gpu/rtc_video_decoder.cc:114: profile =
media::VP9PROFILE_MIN;
On 2017/02/02 00:48:13, Pawel Osciak wrote:
> Would VP9PROFILE_PROFILE0 be better here perhaps?

They are the same enum value. I can change again if you have a strong preference
between these two.

Powered by Google App Engine
This is Rietveld 408576698