Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 2666243003: Revert of perf: Disable mashable.com in tough_ad_cases as it is crashing (Closed)

Created:
3 years, 10 months ago by neis
Modified:
3 years, 10 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of perf: Disable mashable.com in tough_ad_cases as it is crashing (patchset #1 id:1 of https://codereview.chromium.org/2639953003/ ) Reason for revert: The underlying v8 issue has been fixed. Original issue's description: > perf: Disable mashable.com in tough_ad_cases as it is crashing > > BUG=682349 > > Review-Url: https://codereview.chromium.org/2639953003 > Cr-Commit-Position: refs/heads/master@{#444504} > Committed: https://chromium.googlesource.com/chromium/src/+/4a86a5def753c5392ca4a0b21d6ebf409cd44726 TBR=primiano@chromium.org,skyostil@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=682349 Review-Url: https://codereview.chromium.org/2666243003 Cr-Commit-Position: refs/heads/master@{#447543} Committed: https://chromium.googlesource.com/chromium/src/+/9482763db109c161ec334652eb0de31bc2b7140b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M tools/perf/page_sets/tough_ad_cases.py View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
neis
Created Revert of perf: Disable mashable.com in tough_ad_cases as it is crashing
3 years, 10 months ago (2017-02-01 14:35:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2666243003/1
3 years, 10 months ago (2017-02-01 14:35:55 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
3 years, 10 months ago (2017-02-01 14:35:59 UTC) #5
Sami
lgtm, thanks for chasing this!
3 years, 10 months ago (2017-02-01 16:07:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2666243003/1
3 years, 10 months ago (2017-02-01 16:08:33 UTC) #8
commit-bot: I haz the power
3 years, 10 months ago (2017-02-01 17:06:04 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9482763db109c161ec334652eb0d...

Powered by Google App Engine
This is Rietveld 408576698