Move GPUFeatureChecker to content layer

Move GPUFeatureChecker to content layer

The GPUFeatureChecker provides WebGL status to chrome's extension
requirements checker and the webstore private API. Move it to //content so it
can be used from //extensions without relying on //chrome.

This will allow us to move the extension requirements checker out of //chrome
so AppShell can use it (and can check for WebGL support).

BUG=679870
Review-Url: https://codereview.chromium.org/2666243002
Cr-Commit-Position: refs/heads/master@{#450587}
Committed: https://chromium.googlesource.com/chromium/src/+/67362b5be791794950cbfb2b2e5ecb3574ba2e9d

[michaelpg, 2017-02-01 02:08:07]

Description was changed from

==========
Move GPUFeatureChecker to content layer

The GPUFeatureChecker provides WebGL status to chrome's extension requirements
checker and the webstore private API. Move it to //content so it can be used
from //extensions without relying on //chrome.

This will allow us to move the extension requirements checker out of //chrome so
AppShell can use it (and can check for WebGL support).

BUG=679870
R=piman@chromium.org, asargent@chromium.org
==========

to

==========
Move GPUFeatureChecker to content layer

The GPUFeatureChecker provides WebGL status to chrome's extension
requirements checker and the webstore private API. Move it to //content so it
can be used from //extensions without relying on //chrome.

This will allow us to move the extension requirements checker out of //chrome
so AppShell can use it (and can check for WebGL support).

BUG=679870
==========

[michaelpg, 2017-02-01 02:08:07]

michaelpg@chromium.org changed reviewers:
+ finnur@chromium.org, jam@chromium.org, kbr@chromium.org
- asargent@chromium.org, piman@chromium.org

[michaelpg, 2017-02-01 02:15:38]

michaelpg@chromium.org changed reviewers:
- finnur@chromium.org, jam@chromium.org

[michaelpg, 2017-02-01 02:15:39]

PTAL for the GPU stuff. I'll add more OWNERs if you think this looks OK.

[michaelpg, 2017-02-07 00:41:12]

Ken, will you have a chance to look at this CL this week, or could you suggest
an appropriate reviewer? Thanks!

[Ken Russell (switch to Gerrit), 2017-02-07 05:25:37]

kbr@chromium.org changed reviewers:
+ zmo@chromium.org

[Ken Russell (switch to Gerrit), 2017-02-07 05:25:38]

Michael, I'm sorry for the long delay getting to this review. I was in
conferences all last week and am days behind on email and code reviews.

In the future if you don't get a response within 24 hours please find another
owner to review.

It seems reasonable to me to expose this class via the content/ API. Mo (zmo@),
as author of most of these classes, what do you think?

The TODO you added will need to be resolved. I don't know the content/ API's
rules regarding factory methods.

[michaelpg, 2017-02-08 00:00:37]

Patchset #3 (id:40001) has been deleted

[michaelpg, 2017-02-08 00:03:14]

On 2017/02/07 05:25:38, Ken Russell wrote:
> Michael, I'm sorry for the long delay getting to this review. I was in
> conferences all last week and am days behind on email and code reviews.
> 
> In the future if you don't get a response within 24 hours please find another
> owner to review.

Noted. (Not all owners are that punctual anyway.)

> 
> It seems reasonable to me to expose this class via the content/ API. Mo
(zmo@),
> as author of most of these classes, what do you think?
> 
> The TODO you added will need to be resolved. I don't know the content/ API's
> rules regarding factory methods.

Oops, should have been removed, thanks -- that was just a note to self. This
creation pattern is used elsewhere in //content so I don't see it being a
problem.

[Ken Russell (switch to Gerrit), 2017-02-08 00:41:36]

OK, thanks for cleaning up the TODO. LGTM from my standpoint.

[michaelpg, 2017-02-08 20:59:12]

michaelpg@chromium.org changed reviewers:
+ jochen@chromium.org

[michaelpg, 2017-02-08 20:59:12]

michaelpg@chromium.org changed required reviewers:
+ jochen@chromium.org, kbr@chromium.org

[michaelpg, 2017-02-08 20:59:12]

jochen: would you mind looking at the non-GPU stuff?

[jochen (gone - plz use gerrit), 2017-02-09 13:18:06]

lgtm

[michaelpg, 2017-02-14 23:27:57]

The CQ bit was checked by michaelpg@chromium.org

[michaelpg, 2017-02-14 23:27:58]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org,
jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/2666243002/#ps80001
(title: "rebase")

[commit-bot: I haz the power, 2017-02-14 23:29:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-15 06:18:31]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1487114877488800,
"parent_rev": "b1cca1425ef4a0f3174c3feff5ce6a099f6aed95", "commit_rev":
"67362b5be791794950cbfb2b2e5ecb3574ba2e9d"}

[commit-bot: I haz the power, 2017-02-15 06:19:19]

Description was changed from

==========
Move GPUFeatureChecker to content layer

The GPUFeatureChecker provides WebGL status to chrome's extension
requirements checker and the webstore private API. Move it to //content so it
can be used from //extensions without relying on //chrome.

This will allow us to move the extension requirements checker out of //chrome
so AppShell can use it (and can check for WebGL support).

BUG=679870
==========

to

==========
Move GPUFeatureChecker to content layer

The GPUFeatureChecker provides WebGL status to chrome's extension
requirements checker and the webstore private API. Move it to //content so it
can be used from //extensions without relying on //chrome.

This will allow us to move the extension requirements checker out of //chrome
so AppShell can use it (and can check for WebGL support).

BUG=679870

Review-Url: https://codereview.chromium.org/2666243002
Cr-Commit-Position: refs/heads/master@{#450587}
Committed:
https://chromium.googlesource.com/chromium/src/+/67362b5be791794950cbfb2b2e5e...
==========

[commit-bot: I haz the power, 2017-02-15 06:19:20]

Committed patchset #4 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/67362b5be791794950cbfb2b2e5e...