Add VR Services and Daydream hashes and DEPS entry

Add VR Services and Daydream hashes and DEPS entry

Adds sha1 files for Daydream Home and VR Services APK versions 1.0 and 1.1
(the current release version). Also adds DEPS entry to automatically download
them for Android builds.

Also adds *_current.apk.sha1 files to be used for continuous tests on the
chromium.android waterfall. We don't want to clog up the bots running the VR
tests multiple times with different APK versions, so the chromium.android
bots will only test with the most recent release while the other versions can
be tested on our FYI bot for compatibility.

BUG=671373
Review-Url: https://codereview.chromium.org/2666213002
Cr-Commit-Position: refs/heads/master@{#448485}
Committed: https://chromium.googlesource.com/chromium/src/+/93075a8bd2d7f9370aa9f3aa19d1a711f76973f6

[bsheedy, 2017-02-01 01:00:34]

bsheedy@chromium.org changed reviewers:
+ bshe@chromium.org

[bsheedy, 2017-02-01 01:00:34]

PTAL

I can find another reviewer for the DEPS file if you don't think you're in a
position to LGTM.

[bshe, 2017-02-02 20:23:22]

On 2017/02/01 01:00:34, bsheedy wrote:
> PTAL
> 
> I can find another reviewer for the DEPS file if you don't think you're in a
> position to LGTM.

Is there a way to only download these apks on the continuous bots? With this
approach, gclient sync would
download the two apks that most developer wont need. It would be ideal if we can
only download them for 
test bots.

[bsheedy, 2017-02-02 21:12:40]

On 2017/02/02 20:23:22, bshe wrote:
> On 2017/02/01 01:00:34, bsheedy wrote:
> > PTAL
> > 
> > I can find another reviewer for the DEPS file if you don't think you're in a
> > position to LGTM.
> 
> Is there a way to only download these apks on the continuous bots? With this
> approach, gclient sync would
> download the two apks that most developer wont need. It would be ideal if we
can
> only download them for 
> test bots.

+jbudorick@ since he's more knowledgeable about this.

One possible solution I can think of would be to download them as part of the
build process for the VR test APK instead of in DEPS. That won't limit them to
only the bots, but it'll at least prevent everyone from getting it from gclient
sync.

[bsheedy, 2017-02-02 21:12:59]

Description was changed from

==========
Add VR Services and Daydream hashes and DEPS entry

Adds sha1 files for Daydream Home and VR Services APK versions 1.0 and 1.1
(the current release version). Also adds DEPS entry to automatically download
them for Android builds.

Also adds *_current.apk.sha1 files to be used for continuous tests on the
chromium.android waterfall. We don't want to clog up the bots running the VR
tests multiple times with different APK versions, so the chromium.android
bots will only test with the most recent release while the other versions can
be tested on our FYI bot for compatibility.

BUG=671373
==========

to

==========
Add VR Services and Daydream hashes and DEPS entry

Adds sha1 files for Daydream Home and VR Services APK versions 1.0 and 1.1
(the current release version). Also adds DEPS entry to automatically download
them for Android builds.

Also adds *_current.apk.sha1 files to be used for continuous tests on the
chromium.android waterfall. We don't want to clog up the bots running the VR
tests multiple times with different APK versions, so the chromium.android
bots will only test with the most recent release while the other versions can
be tested on our FYI bot for compatibility.

BUG=671373
==========

[bsheedy, 2017-02-02 21:13:00]

bsheedy@chromium.org changed reviewers:
+ jbudorick@chromium.org

[jbudorick, 2017-02-03 17:29:50]

On 2017/02/02 21:12:40, bsheedy wrote:
> On 2017/02/02 20:23:22, bshe wrote:
> > On 2017/02/01 01:00:34, bsheedy wrote:
> > > PTAL
> > > 
> > > I can find another reviewer for the DEPS file if you don't think you're in
a
> > > position to LGTM.
> > 
> > Is there a way to only download these apks on the continuous bots? With this
> > approach, gclient sync would
> > download the two apks that most developer wont need. It would be ideal if we
> can
> > only download them for 
> > test bots.
> 
> +jbudorick@ since he's more knowledgeable about this.

yeah, this is possible, and there's more than one mechanism:
 - set custom_deps for the bot configuration
 - have the bot separately download the APKs from GS

> 
> One possible solution I can think of would be to download them as part of the
> build process for the VR test APK instead of in DEPS. That won't limit them to
> only the bots, but it'll at least prevent everyone from getting it from
gclient
> sync.

I'd recommend against this. If these APKs are necessary for tests, then we
should be downloading them at runhooks time.

[bsheedy, 2017-02-03 23:11:25]

I'll be adding the hooks to the bot gclient config.py, but that looks like it
can only be done via the internal depot_tools repo. I've changed this CL to only
include the hashes and README change, so nothing should be affected yet.

[bshe, 2017-02-07 00:22:50]

On 2017/02/03 23:11:25, bsheedy wrote:
> I'll be adding the hooks to the bot gclient config.py, but that looks like it
> can only be done via the internal depot_tools repo. I've changed this CL to
only
> include the hashes and README change, so nothing should be affected yet.

lgtm. Thanks!

[bsheedy, 2017-02-07 00:55:49]

The CQ bit was checked by bsheedy@chromium.org

[commit-bot: I haz the power, 2017-02-07 00:56:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-07 01:11:06]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1486428949775940,
"parent_rev": "d67353a42642aa01e0c506ff1c24ef185aeedb4c", "commit_rev":
"93075a8bd2d7f9370aa9f3aa19d1a711f76973f6"}

[commit-bot: I haz the power, 2017-02-07 01:11:59]

Description was changed from

==========
Add VR Services and Daydream hashes and DEPS entry

Adds sha1 files for Daydream Home and VR Services APK versions 1.0 and 1.1
(the current release version). Also adds DEPS entry to automatically download
them for Android builds.

Also adds *_current.apk.sha1 files to be used for continuous tests on the
chromium.android waterfall. We don't want to clog up the bots running the VR
tests multiple times with different APK versions, so the chromium.android
bots will only test with the most recent release while the other versions can
be tested on our FYI bot for compatibility.

BUG=671373
==========

to

==========
Add VR Services and Daydream hashes and DEPS entry

Adds sha1 files for Daydream Home and VR Services APK versions 1.0 and 1.1
(the current release version). Also adds DEPS entry to automatically download
them for Android builds.

Also adds *_current.apk.sha1 files to be used for continuous tests on the
chromium.android waterfall. We don't want to clog up the bots running the VR
tests multiple times with different APK versions, so the chromium.android
bots will only test with the most recent release while the other versions can
be tested on our FYI bot for compatibility.

BUG=671373

Review-Url: https://codereview.chromium.org/2666213002
Cr-Commit-Position: refs/heads/master@{#448485}
Committed:
https://chromium.googlesource.com/chromium/src/+/93075a8bd2d7f9370aa9f3aa19d1...
==========

[commit-bot: I haz the power, 2017-02-07 01:12:01]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/93075a8bd2d7f9370aa9f3aa19d1...