Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Unified Diff: components/renderer_context_menu/render_view_context_menu_base.cc

Issue 2666193002: Switch RenderViewContextMenu to use RequestOpenURL (Closed)
Patch Set: Address Charlie's comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/renderer_context_menu/render_view_context_menu_base.cc
diff --git a/components/renderer_context_menu/render_view_context_menu_base.cc b/components/renderer_context_menu/render_view_context_menu_base.cc
index a3e0e50f317074c8e7d6485f99fa6079b7da737d..2b7e0caf7cc6e9033f09c88aa21e9f8af2e33307 100644
--- a/components/renderer_context_menu/render_view_context_menu_base.cc
+++ b/components/renderer_context_menu/render_view_context_menu_base.cc
@@ -393,11 +393,10 @@ void RenderViewContextMenuBase::OpenURLWithExtraHeaders(
if (!extra_headers.empty())
open_url_params.extra_headers = extra_headers;
- WebContents* new_contents = source_web_contents_->OpenURL(open_url_params);
- if (!new_contents)
- return;
+ open_url_params.source_render_process_id = render_process_id_;
+ open_url_params.source_render_frame_id = render_frame_id_;
- NotifyURLOpened(url, new_contents);
+ source_web_contents_->OpenURL(open_url_params);
}
bool RenderViewContextMenuBase::IsCustomItemChecked(int id) const {

Powered by Google App Engine
This is Rietveld 408576698