Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1701)

Unified Diff: content/test/web_contents_observer_sanity_checker.cc

Issue 2666193002: Switch RenderViewContextMenu to use RequestOpenURL (Closed)
Patch Set: cleanup Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/test/web_contents_observer_sanity_checker.cc
diff --git a/content/test/web_contents_observer_sanity_checker.cc b/content/test/web_contents_observer_sanity_checker.cc
index ae9af67dc0e60f3940fa47bb76bd591838b4b08f..84b3e6466f13952e95f857492e3ce380e3431492 100644
--- a/content/test/web_contents_observer_sanity_checker.cc
+++ b/content/test/web_contents_observer_sanity_checker.cc
@@ -279,8 +279,9 @@ void WebContentsObserverSanityChecker::DidOpenRequestedURL(
const GURL& url,
const Referrer& referrer,
WindowOpenDisposition disposition,
- ui::PageTransition transition) {
- AssertRenderFrameExists(source_render_frame_host);
+ ui::PageTransition transition,
+ bool started_from_context_menu) {
+ // AssertRenderFrameExists(source_render_frame_host);
nasko 2017/02/14 00:10:23 This shouldn't be commented out.
Patrick Noland 2017/02/14 01:16:16 Done.
}
void WebContentsObserverSanityChecker::MediaStartedPlaying(

Powered by Google App Engine
This is Rietveld 408576698