Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(867)

Side by Side Diff: content/test/web_contents_observer_sanity_checker.cc

Issue 2666193002: Switch RenderViewContextMenu to use RequestOpenURL (Closed)
Patch Set: cleanup Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/test/web_contents_observer_sanity_checker.h" 5 #include "content/test/web_contents_observer_sanity_checker.h"
6 6
7 #include "base/strings/stringprintf.h" 7 #include "base/strings/stringprintf.h"
8 #include "build/build_config.h" 8 #include "build/build_config.h"
9 #include "content/browser/frame_host/render_frame_host_impl.h" 9 #include "content/browser/frame_host/render_frame_host_impl.h"
10 #include "content/common/frame_messages.h" 10 #include "content/common/frame_messages.h"
(...skipping 261 matching lines...) Expand 10 before | Expand all | Expand 10 after
272 bool was_ignored_by_handler) { 272 bool was_ignored_by_handler) {
273 AssertRenderFrameExists(render_frame_host); 273 AssertRenderFrameExists(render_frame_host);
274 } 274 }
275 275
276 void WebContentsObserverSanityChecker::DidOpenRequestedURL( 276 void WebContentsObserverSanityChecker::DidOpenRequestedURL(
277 WebContents* new_contents, 277 WebContents* new_contents,
278 RenderFrameHost* source_render_frame_host, 278 RenderFrameHost* source_render_frame_host,
279 const GURL& url, 279 const GURL& url,
280 const Referrer& referrer, 280 const Referrer& referrer,
281 WindowOpenDisposition disposition, 281 WindowOpenDisposition disposition,
282 ui::PageTransition transition) { 282 ui::PageTransition transition,
283 AssertRenderFrameExists(source_render_frame_host); 283 bool started_from_context_menu) {
284 // AssertRenderFrameExists(source_render_frame_host);
nasko 2017/02/14 00:10:23 This shouldn't be commented out.
Patrick Noland 2017/02/14 01:16:16 Done.
284 } 285 }
285 286
286 void WebContentsObserverSanityChecker::MediaStartedPlaying( 287 void WebContentsObserverSanityChecker::MediaStartedPlaying(
287 const MediaPlayerInfo& media_info, 288 const MediaPlayerInfo& media_info,
288 const MediaPlayerId& id) { 289 const MediaPlayerId& id) {
289 CHECK(!web_contents_destroyed_); 290 CHECK(!web_contents_destroyed_);
290 CHECK(std::find(active_media_players_.begin(), active_media_players_.end(), 291 CHECK(std::find(active_media_players_.begin(), active_media_players_.end(),
291 id) == active_media_players_.end()); 292 id) == active_media_players_.end());
292 active_media_players_.push_back(id); 293 active_media_players_.push_back(id);
293 } 294 }
(...skipping 112 matching lines...) Expand 10 before | Expand all | Expand 10 after
406 if (live_routes_.count(entry.first)) 407 if (live_routes_.count(entry.first))
407 return true; 408 return true;
408 if (current_hosts_.count(entry.first)) 409 if (current_hosts_.count(entry.first))
409 return true; 410 return true;
410 } 411 }
411 } 412 }
412 return false; 413 return false;
413 } 414 }
414 415
415 } // namespace content 416 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698