Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2021)

Issue 2666173002: Add support to validate list of items in json5 config. (Closed)

Created:
3 years, 10 months ago by ktyliu
Modified:
3 years, 10 months ago
Reviewers:
sashab, aazzam
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add support to validate list of items in json5 config. Allow both forms of list validation in JSON5 config: 1. ensure list is exactly as specified (current) parameters: { exact_list_param: { valid_type: "list", valid_values: [ ["a", "b"], ["b", "a"], ], }, }, 2. ensure each item in list is in valid_values (new) parameters: { api_method: { valid_type: "list", valid_values: ["parseSingleValue", "parseShortHand"], }, }, BUG=677884 Review-Url: https://codereview.chromium.org/2666173002 Cr-Commit-Position: refs/heads/master@{#447378} Committed: https://chromium.googlesource.com/chromium/src/+/2028c664f02f529fa688418bc7607800bf7dc521

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -4 lines) Patch
M third_party/WebKit/Source/build/scripts/json5_generator.py View 1 chunk +13 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
ktyliu
Hi Anna, As discussed, this simple improvement allows us to specify valid values for list ...
3 years, 10 months ago (2017-01-31 22:41:16 UTC) #4
sashab
LGTM but wait for annas review as well :)
3 years, 10 months ago (2017-01-31 22:44:11 UTC) #5
aazzam
looks awesome! lgtm :)
3 years, 10 months ago (2017-01-31 22:45:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2666173002/1
3 years, 10 months ago (2017-01-31 22:58:02 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-01 00:10:33 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2028c664f02f529fa688418bc760...

Powered by Google App Engine
This is Rietveld 408576698