Added new type of unit test, RAW_UNIT_TEST_CASE, which is used for tests that can be flaky if run w…

runtime/bin/run_vm_tests.cc

Index: runtime/bin/run_vm_tests.cc
diff --git a/runtime/bin/run_vm_tests.cc b/runtime/bin/run_vm_tests.cc
index c6e11b40d35eb75745f2de884ff9784241a2a520..8d49fe077baff3d1feec009fd5d437758e65f3ea 100644
--- a/runtime/bin/run_vm_tests.cc
+++ b/runtime/bin/run_vm_tests.cc
@@ -41,6 +41,13 @@ void TestCase::Run() {
 }
 
 
+void RawTestCase::Run() {
+  fprintf(stdout, "Running test: %s\n", name());

[rmacnak, 2017/01/31 21:43:42]

OS::Print

[bkonyi, 2017/01/31 22:14:35]

fprintf is used throughout run_vm_tests.cc. Should these other instances be
switched to use OS::Print or should I just stick with fprintf?

[rmacnak, 2017/01/31 22:44:39]

They ought to be OS::Print so one can actually read the output on Android/iOS,
but you don't need to update them in this CL.

[bkonyi, 2017/01/31 22:57:18]

Ah okay. I'll update all of the fprintf instances (including this one) in
another CL then.

+  (*run_)();
+  fprintf(stdout, "Done: %s\n", name());
+}
+
+
 void TestCaseBase::RunTest() {
   if (strcmp(run_filter, this->name()) == 0) {
     this->Run();
@@ -90,6 +97,7 @@ static int Main(int argc, const char** argv) {
       // List all tests and benchmarks and exit without initializing the VM.
       TestCaseBase::RunAll();
       Benchmark::RunAll(argv[0]);
+      TestCaseBase::RunAllRaw();
       fflush(stdout);
       return 0;
     } else if (strcmp(argv[1], "--benchmarks") == 0) {
@@ -122,6 +130,7 @@ static int Main(int argc, const char** argv) {
   err_msg = Dart::Cleanup();
   ASSERT(err_msg == NULL);
 
+  TestCaseBase::RunAllRaw();

[bkonyi, 2017/01/31 20:59:50]

The raw tests are run after the VM is shutdown since the MallocHooks
implementation is using MutexLockers, which require that there is a current
thread. This is initialized in OSThread::InitOnce(), so we can't run those tests
until after the VM has been initialized. Since Dart::Cleanup() doesn't actually
cleanup anything in OSThread::Cleanup(), at this point there is still a current
thread but the VM has been shutdown. This feels like a bit of a hack, so someone
else might have a better solution.

   // Print a warning message if no tests or benchmarks were matched.
   if (run_matches == 0) {
     fprintf(stderr, "No tests matched: %s\n", run_filter);