Added new type of unit test, RAW_UNIT_TEST_CASE, which is used for tests that can be flaky if run w…

runtime/bin/run_vm_tests.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include <stdio.h>
 
 #include "bin/dartutils.h"
 #include "bin/file.h"
 #include "bin/platform.h"
 #include "platform/assert.h"
@@ skipping 23 matching lines @@
 static int run_matches = 0;
 
 
 void TestCase::Run() {
   fprintf(stdout, "Running test: %s\n", name());
   (*run_)();
   fprintf(stdout, "Done: %s\n", name());
 }
 
 
+void RawTestCase::Run() {
+  fprintf(stdout, "Running test: %s\n", name());

[rmacnak, 2017/01/31 21:43:42]

OS::Print

[bkonyi, 2017/01/31 22:14:35]

fprintf is used throughout run_vm_tests.cc. Should these other instances be
switched to use OS::Print or should I just stick with fprintf?

[rmacnak, 2017/01/31 22:44:39]

They ought to be OS::Print so one can actually read the output on Android/iOS,
but you don't need to update them in this CL.

[bkonyi, 2017/01/31 22:57:18]

Ah okay. I'll update all of the fprintf instances (including this one) in
another CL then.

+  (*run_)();
+  fprintf(stdout, "Done: %s\n", name());
+}
+
+
 void TestCaseBase::RunTest() {
   if (strcmp(run_filter, this->name()) == 0) {
     this->Run();
     run_matches++;
   } else if (run_filter == kList) {
     fprintf(stdout, "%s\n", this->name());
     run_matches++;
   }
 }
 
@@ skipping 29 matching lines @@
   if (argc < 2) {
     // Bad parameter count.
     PrintUsage();
     return 1;
   } else if (argc == 2) {
     if (strcmp(argv[1], "--list") == 0) {
       run_filter = kList;
       // List all tests and benchmarks and exit without initializing the VM.
       TestCaseBase::RunAll();
       Benchmark::RunAll(argv[0]);
+      TestCaseBase::RunAllRaw();
       fflush(stdout);
       return 0;
     } else if (strcmp(argv[1], "--benchmarks") == 0) {
       run_filter = kAllBenchmarks;
     } else {
       run_filter = argv[1];
     }
   } else {
     // Last argument is the test name, the rest are vm flags.
     run_filter = argv[argc - 1];
@@ skipping 12 matching lines @@
       dart::bin::DartUtils::CloseFile, NULL, NULL);
   ASSERT(err_msg == NULL);
   // Apply the filter to all registered tests.
   TestCaseBase::RunAll();
   // Apply the filter to all registered benchmarks.
   Benchmark::RunAll(argv[0]);
 
   err_msg = Dart::Cleanup();
   ASSERT(err_msg == NULL);
 
+  TestCaseBase::RunAllRaw();

[bkonyi, 2017/01/31 20:59:50]

The raw tests are run after the VM is shutdown since the MallocHooks
implementation is using MutexLockers, which require that there is a current
thread. This is initialized in OSThread::InitOnce(), so we can't run those tests
until after the VM has been initialized. Since Dart::Cleanup() doesn't actually
cleanup anything in OSThread::Cleanup(), at this point there is still a current
thread but the VM has been shutdown. This feels like a bit of a hack, so someone
else might have a better solution.

   // Print a warning message if no tests or benchmarks were matched.
   if (run_matches == 0) {
     fprintf(stderr, "No tests matched: %s\n", run_filter);
     return 1;
   }
   if (DynamicAssertionHelper::failed()) {
     return 255;
   }
   return 0;
 }
 
 }  // namespace dart
 
 
 int main(int argc, const char** argv) {
   dart::bin::Platform::Exit(dart::Main(argc, argv));
 }