Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2666113002: Skip some tests that depend on a file with a non-utf8 encoding. (Closed)

Created:
3 years, 10 months ago by qyearsley
Modified:
3 years, 10 months ago
Reviewers:
tkent, jeffcarp
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Skip some tests that depend on a file with a non-utf8 encoding. TBR=jeffcarp,tkent TBR_REASON=Unblocking the W3C test autoroller BUG=656171 Review-Url: https://codereview.chromium.org/2666113002 Cr-Commit-Position: refs/heads/master@{#447303} Committed: https://chromium.googlesource.com/chromium/src/+/c7082389df8da5959441981c484ffd94f3190928

Patch Set 1 #

Patch Set 2 : Remove files that are now skipped #

Messages

Total messages: 20 (11 generated)
qyearsley
3 years, 10 months ago (2017-01-31 19:07:02 UTC) #7
qyearsley
By the way, please let me know if this is something that I shouldn't TBR ...
3 years, 10 months ago (2017-01-31 19:34:29 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2666113002/20001
3 years, 10 months ago (2017-01-31 19:35:14 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/c7082389df8da5959441981c484ffd94f3190928
3 years, 10 months ago (2017-01-31 19:43:47 UTC) #15
qyearsley
On 2017/01/31 at 19:34:29, qyearsley wrote: > By the way, please let me know if ...
3 years, 10 months ago (2017-01-31 22:07:30 UTC) #16
jeffcarp
On 2017/01/31 at 22:07:30, qyearsley wrote: > On 2017/01/31 at 19:34:29, qyearsley wrote: > > ...
3 years, 10 months ago (2017-02-01 03:05:42 UTC) #17
tkent
TBR is ok, however why did they block autoroll? *.js files are not parsed in ...
3 years, 10 months ago (2017-02-01 16:27:14 UTC) #18
qyearsley
On 2017/02/01 at 16:27:14, tkent wrote: > TBR is ok, however why did they block ...
3 years, 10 months ago (2017-02-01 16:55:44 UTC) #19
tkent
3 years, 10 months ago (2017-02-01 22:58:48 UTC) #20
Message was sent while issue was closed.
On 2017/02/01 at 16:55:44, qyearsley wrote:
> On 2017/02/01 at 16:27:14, tkent wrote:
> > TBR is ok, however why did they block autoroll?  *.js files are not parsed
in wpt-import, right?
> 
> The part that couldn't handle the encoding wasn't in wpt-import -- it was
somewhere in the CL upload, or processsing in Rietveld, or on the try bot
applying the patch - still not sure where, or exactly how it got mangled :-/

Oh, I see.
Non-UTF8 test files should be valid.  We need investigation.

LGTM anyway.

Powered by Google App Engine
This is Rietveld 408576698