Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(724)

Unified Diff: ios/web/web_state/ui/web_view_js_utils.mm

Issue 2666093002: Remove base::FundamentalValue (Closed)
Patch Set: Rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/web/web_state/ui/web_view_js_utils.mm
diff --git a/ios/web/web_state/ui/web_view_js_utils.mm b/ios/web/web_state/ui/web_view_js_utils.mm
index 94c73464380bf7d237d6e786c3c85f00e5b9edc9..50e4f42b1365126da8e1fe0782d1490349968fd4 100644
--- a/ios/web/web_state/ui/web_view_js_utils.mm
+++ b/ios/web/web_state/ui/web_view_js_utils.mm
@@ -35,11 +35,10 @@ std::unique_ptr<base::Value> ValueResultFromWKResult(id wk_result,
result.reset(new base::StringValue(base::SysNSStringToUTF16(wk_result)));
DCHECK(result->IsType(base::Value::Type::STRING));
} else if (result_type == CFNumberGetTypeID()) {
- result.reset(new base::FundamentalValue([wk_result doubleValue]));
+ result.reset(new base::Value([wk_result doubleValue]));
DCHECK(result->IsType(base::Value::Type::DOUBLE));
} else if (result_type == CFBooleanGetTypeID()) {
- result.reset(
- new base::FundamentalValue(static_cast<bool>([wk_result boolValue])));
+ result.reset(new base::Value(static_cast<bool>([wk_result boolValue])));
DCHECK(result->IsType(base::Value::Type::BOOLEAN));
} else if (result_type == CFNullGetTypeID()) {
result = base::Value::CreateNullValue();
« no previous file with comments | « ios/chrome/browser/ui/webui/sync_internals/sync_internals_message_handler.cc ('k') | ios/web/webui/mojo_facade.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698