ios/chrome/browser/ui/webui/sync_internals/sync_internals_message_handler.cc - Issue 2666093002: Remove base::FundamentalValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/ui/webui/sync_internals/sync_internals_message_handler.cc

Issue 2666093002: Remove base::FundamentalValue (Closed)

Patch Set: Rebase Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ios/chrome/browser/ui/webui/sync_internals/sync_internals_message_handler.cc

diff --git a/ios/chrome/browser/ui/webui/sync_internals/sync_internals_message_handler.cc b/ios/chrome/browser/ui/webui/sync_internals/sync_internals_message_handler.cc

index 7f4b3cbeb5957d37cc4fd7ddff2bfc6d94046f8f..8ee1b6145de21fa2c519d9cd77c3e9636e4a7ce6 100644

--- a/ios/chrome/browser/ui/webui/sync_internals/sync_internals_message_handler.cc

+++ b/ios/chrome/browser/ui/webui/sync_internals/sync_internals_message_handler.cc

@@ -152,7 +152,7 @@ void SyncInternalsMessageHandler::HandleGetAllNodes(

void SyncInternalsMessageHandler::OnReceivedAllNodes(

int request_id,

std::unique_ptr<base::ListValue> nodes) {

- base::FundamentalValue id(request_id);

+ base::Value id(request_id);

web_ui()->CallJavascriptFunction(syncer::sync_ui_util::kGetAllNodesCallback,

id, *nodes);

}

« no previous file with comments | « ios/chrome/browser/ui/webui/crashes_ui.cc ('k') | ios/web/web_state/ui/web_view_js_utils.mm » ('j') | no next file with comments »