Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1626)

Unified Diff: extensions/renderer/argument_spec.cc

Issue 2666093002: Remove base::FundamentalValue (Closed)
Patch Set: Rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/common/value_builder.cc ('k') | headless/public/domains/types_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/argument_spec.cc
diff --git a/extensions/renderer/argument_spec.cc b/extensions/renderer/argument_spec.cc
index a4def1d53e2ea8beed01f8a5dda850b9889ca53f..c71e0e70b7f347d24561b13493d04f4ba98c19d5 100644
--- a/extensions/renderer/argument_spec.cc
+++ b/extensions/renderer/argument_spec.cc
@@ -26,7 +26,7 @@ bool ParseFundamentalValueHelper(v8::Local<v8::Value> arg,
if (minimum && val < minimum.value())
return false;
if (out_value)
- *out_value = base::MakeUnique<base::FundamentalValue>(val);
+ *out_value = base::MakeUnique<base::Value>(val);
return true;
}
@@ -238,8 +238,8 @@ bool ArgumentSpec::ParseArgumentToFundamental(
if (!value->IsBoolean())
return false;
if (out_value) {
- *out_value = base::MakeUnique<base::FundamentalValue>(
- value.As<v8::Boolean>()->Value());
+ *out_value =
+ base::MakeUnique<base::Value>(value.As<v8::Boolean>()->Value());
}
return true;
}
« no previous file with comments | « extensions/common/value_builder.cc ('k') | headless/public/domains/types_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698