Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Unified Diff: extensions/common/value_builder.cc

Issue 2666093002: Remove base::FundamentalValue (Closed)
Patch Set: Rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/common/value_builder.cc
diff --git a/extensions/common/value_builder.cc b/extensions/common/value_builder.cc
index a288875e3d3751672ba5aef3181caed2fbfbecd4..08bb7de1e1e85f816cd6696af1cf95795d3ce4e2 100644
--- a/extensions/common/value_builder.cc
+++ b/extensions/common/value_builder.cc
@@ -30,15 +30,13 @@ std::string DictionaryBuilder::ToJSON() const {
DictionaryBuilder& DictionaryBuilder::Set(const std::string& path,
int in_value) {
- dict_->SetWithoutPathExpansion(
- path, base::MakeUnique<base::FundamentalValue>(in_value));
+ dict_->SetWithoutPathExpansion(path, base::MakeUnique<base::Value>(in_value));
return *this;
}
DictionaryBuilder& DictionaryBuilder::Set(const std::string& path,
double in_value) {
- dict_->SetWithoutPathExpansion(
- path, base::MakeUnique<base::FundamentalValue>(in_value));
+ dict_->SetWithoutPathExpansion(path, base::MakeUnique<base::Value>(in_value));
return *this;
}
@@ -65,8 +63,7 @@ DictionaryBuilder& DictionaryBuilder::Set(
DictionaryBuilder& DictionaryBuilder::SetBoolean(
const std::string& path, bool in_value) {
- dict_->SetWithoutPathExpansion(
- path, base::MakeUnique<base::FundamentalValue>(in_value));
+ dict_->SetWithoutPathExpansion(path, base::MakeUnique<base::Value>(in_value));
return *this;
}
« no previous file with comments | « extensions/browser/value_store/value_store_frontend_unittest.cc ('k') | extensions/renderer/argument_spec.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698