extensions/browser/api/hid/hid_api.cc - Issue 2666093002: Remove base::FundamentalValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/hid/hid_api.cc

Issue 2666093002: Remove base::FundamentalValue (Closed)

Patch Set: Rebase Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/api/hid/hid_api.cc

diff --git a/extensions/browser/api/hid/hid_api.cc b/extensions/browser/api/hid/hid_api.cc

index 6f816ef7adb1cf4b1701fe1ab3eda5f146e88afb..0f8fb5064e31dd71401f542546893e1f2fa7571a 100644

--- a/extensions/browser/api/hid/hid_api.cc

+++ b/extensions/browser/api/hid/hid_api.cc

@@ -268,7 +268,7 @@ void HidReceiveFunction::OnFinished(bool success,

DCHECK_GE(size, 1u);

int report_id = reinterpret_cast<uint8_t*>(buffer->data())[0];

- Respond(TwoArguments(base::MakeUnique<base::FundamentalValue>(report_id),

+ Respond(TwoArguments(base::MakeUnique<base::Value>(report_id),

base::BinaryValue::CreateWithCopiedBuffer(

buffer->data() + 1, size - 1)));

} else {