extensions/browser/api/guest_view/web_view/web_view_internal_api.cc - Issue 2666093002: Remove base::FundamentalValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/guest_view/web_view/web_view_internal_api.cc

Issue 2666093002: Remove base::FundamentalValue (Closed)

Patch Set: Rebase Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/api/guest_view/extension_view/extension_view_internal_api.cc ('k') | extensions/browser/api/hid/hid_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/guest_view/web_view/web_view_internal_api.cc

diff --git a/extensions/browser/api/guest_view/web_view/web_view_internal_api.cc b/extensions/browser/api/guest_view/web_view/web_view_internal_api.cc

index 6852ff51d9d267860315f048c0bf3573565da81c..a910b4ae62f7bca4a3bef9de553d8efbae9986df 100644

--- a/extensions/browser/api/guest_view/web_view/web_view_internal_api.cc

+++ b/extensions/browser/api/guest_view/web_view/web_view_internal_api.cc

@@ -644,8 +644,7 @@ ExtensionFunction::ResponseAction WebViewInternalGetZoomFunction::Run() {

EXTENSION_FUNCTION_VALIDATE(params.get());

double zoom_factor = guest_->GetZoom();

- return RespondNow(

- OneArgument(base::MakeUnique<base::FundamentalValue>(zoom_factor)));

+ return RespondNow(OneArgument(base::MakeUnique<base::Value>(zoom_factor)));

}

WebViewInternalSetZoomModeFunction::WebViewInternalSetZoomModeFunction() {

@@ -807,8 +806,7 @@ ExtensionFunction::ResponseAction WebViewInternalGoFunction::Run() {

EXTENSION_FUNCTION_VALIDATE(params.get());

bool successful = guest_->Go(params->relative_index);

- return RespondNow(

- OneArgument(base::MakeUnique<base::FundamentalValue>(successful)));

+ return RespondNow(OneArgument(base::MakeUnique<base::Value>(successful)));

}

WebViewInternalReloadFunction::WebViewInternalReloadFunction() {

@@ -862,7 +860,7 @@ ExtensionFunction::ResponseAction WebViewInternalSetPermissionFunction::Run() {

EXTENSION_FUNCTION_VALIDATE(result !=

WebViewPermissionHelper::SET_PERMISSION_INVALID);

- return RespondNow(OneArgument(base::MakeUnique<base::FundamentalValue>(

+ return RespondNow(OneArgument(base::MakeUnique<base::Value>(

result == WebViewPermissionHelper::SET_PERMISSION_ALLOWED)));

}