content/common/android/gin_java_bridge_value_unittest.cc - Issue 2666093002: Remove base::FundamentalValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/android/gin_java_bridge_value_unittest.cc

Issue 2666093002: Remove base::FundamentalValue (Closed)

Patch Set: Rebase Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/common/android/gin_java_bridge_value_unittest.cc

diff --git a/content/common/android/gin_java_bridge_value_unittest.cc b/content/common/android/gin_java_bridge_value_unittest.cc

index 7f20294a0b8fbd307dd8472563870b170102f0ce..0dc27d24f5c3840e67343e28e5bf0cca60d095bf 100644

--- a/content/common/android/gin_java_bridge_value_unittest.cc

+++ b/content/common/android/gin_java_bridge_value_unittest.cc

@@ -78,7 +78,7 @@ TEST_F(GinJavaBridgeValueTest, BasicValues) {

}

TEST_F(GinJavaBridgeValueTest, BrokenValues) {

- std::unique_ptr<base::Value> non_binary(new base::FundamentalValue(42));

+ std::unique_ptr<base::Value> non_binary(new base::Value(42));

EXPECT_FALSE(

GinJavaBridgeValue::ContainsGinJavaBridgeValue(non_binary.get()));