Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Unified Diff: content/child/v8_value_converter_impl_unittest.cc

Issue 2666093002: Remove base::FundamentalValue (Closed)
Patch Set: Rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/child/v8_value_converter_impl.cc ('k') | content/common/android/gin_java_bridge_value_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/child/v8_value_converter_impl_unittest.cc
diff --git a/content/child/v8_value_converter_impl_unittest.cc b/content/child/v8_value_converter_impl_unittest.cc
index c08bc57c9eb9e2b36699007dfad0f2478eb7c561..83bf27e917b6048aa5c16754e8cd43a998fe0d22 100644
--- a/content/child/v8_value_converter_impl_unittest.cc
+++ b/content/child/v8_value_converter_impl_unittest.cc
@@ -414,7 +414,7 @@ TEST_F(V8ValueConverterImplTest, WeirdTypes) {
converter.SetDateAllowed(true);
TestWeirdType(converter, v8::Date::New(isolate_, 1000),
base::Value::Type::DOUBLE,
- std::unique_ptr<base::Value>(new base::FundamentalValue(1.0)));
+ std::unique_ptr<base::Value>(new base::Value(1.0)));
converter.SetRegExpAllowed(true);
TestWeirdType(converter, regex, base::Value::Type::STRING,
« no previous file with comments | « content/child/v8_value_converter_impl.cc ('k') | content/common/android/gin_java_bridge_value_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698