Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1387)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: components/prefs/pref_value_store_unittest.cc

Issue 2666093002: Remove base::FundamentalValue (Closed)
Patch Set: Rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/prefs/pref_value_map_unittest.cc ('k') | components/prefs/testing_pref_store.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/prefs/pref_value_store_unittest.cc
diff --git a/components/prefs/pref_value_store_unittest.cc b/components/prefs/pref_value_store_unittest.cc
index 23fc686e17cee530644ff0e62f7fc1a579c26837..7ef66eb56934fcd06cbe0e8d38512d7a0bbf0d61 100644
--- a/components/prefs/pref_value_store_unittest.cc
+++ b/components/prefs/pref_value_store_unittest.cc
@@ -321,7 +321,7 @@ TEST_F(PrefValueStoreTest, GetValue) {
// Test getting a preference value that the |PrefValueStore|
// does not contain.
- base::FundamentalValue tmp_dummy_value(true);
+ base::Value tmp_dummy_value(true);
value = &tmp_dummy_value;
ASSERT_FALSE(pref_value_store_->GetValue(prefs::kMissingPref,
base::Value::Type::STRING, &value));
@@ -386,7 +386,7 @@ TEST_F(PrefValueStoreTest, GetRecommendedValue) {
actual_str_value);
// Test getting recommended value when no recommended value is present.
- base::FundamentalValue tmp_dummy_value(true);
+ base::Value tmp_dummy_value(true);
value = &tmp_dummy_value;
ASSERT_FALSE(pref_value_store_->GetRecommendedValue(
prefs::kDefaultPref,
« no previous file with comments | « components/prefs/pref_value_map_unittest.cc ('k') | components/prefs/testing_pref_store.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698