Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Side by Side Diff: components/prefs/pref_value_store_unittest.cc

Issue 2666093002: Remove base::FundamentalValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/prefs/pref_value_map_unittest.cc ('k') | components/prefs/testing_pref_store.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/prefs/pref_value_store.h" 5 #include "components/prefs/pref_value_store.h"
6 6
7 #include <memory> 7 #include <memory>
8 #include <string> 8 #include <string>
9 9
10 #include "base/bind.h" 10 #include "base/bind.h"
(...skipping 303 matching lines...) Expand 10 before | Expand all | Expand 10 after
314 314
315 // Test getting a default value. 315 // Test getting a default value.
316 value = NULL; 316 value = NULL;
317 ASSERT_TRUE(pref_value_store_->GetValue(prefs::kDefaultPref, 317 ASSERT_TRUE(pref_value_store_->GetValue(prefs::kDefaultPref,
318 base::Value::Type::STRING, &value)); 318 base::Value::Type::STRING, &value));
319 EXPECT_TRUE(value->GetAsString(&actual_str_value)); 319 EXPECT_TRUE(value->GetAsString(&actual_str_value));
320 EXPECT_EQ(default_pref::kDefaultValue, actual_str_value); 320 EXPECT_EQ(default_pref::kDefaultValue, actual_str_value);
321 321
322 // Test getting a preference value that the |PrefValueStore| 322 // Test getting a preference value that the |PrefValueStore|
323 // does not contain. 323 // does not contain.
324 base::FundamentalValue tmp_dummy_value(true); 324 base::Value tmp_dummy_value(true);
325 value = &tmp_dummy_value; 325 value = &tmp_dummy_value;
326 ASSERT_FALSE(pref_value_store_->GetValue(prefs::kMissingPref, 326 ASSERT_FALSE(pref_value_store_->GetValue(prefs::kMissingPref,
327 base::Value::Type::STRING, &value)); 327 base::Value::Type::STRING, &value));
328 ASSERT_FALSE(value); 328 ASSERT_FALSE(value);
329 } 329 }
330 330
331 TEST_F(PrefValueStoreTest, GetRecommendedValue) { 331 TEST_F(PrefValueStoreTest, GetRecommendedValue) {
332 const base::Value* value; 332 const base::Value* value;
333 333
334 // The following tests read a value from the PrefService. The preferences are 334 // The following tests read a value from the PrefService. The preferences are
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
379 // Test getting recommended value when no higher-priority value is present. 379 // Test getting recommended value when no higher-priority value is present.
380 value = NULL; 380 value = NULL;
381 ASSERT_TRUE(pref_value_store_->GetRecommendedValue( 381 ASSERT_TRUE(pref_value_store_->GetRecommendedValue(
382 prefs::kRecommendedPref, 382 prefs::kRecommendedPref,
383 base::Value::Type::STRING, &value)); 383 base::Value::Type::STRING, &value));
384 EXPECT_TRUE(value->GetAsString(&actual_str_value)); 384 EXPECT_TRUE(value->GetAsString(&actual_str_value));
385 EXPECT_EQ(recommended_pref::kRecommendedValue, 385 EXPECT_EQ(recommended_pref::kRecommendedValue,
386 actual_str_value); 386 actual_str_value);
387 387
388 // Test getting recommended value when no recommended value is present. 388 // Test getting recommended value when no recommended value is present.
389 base::FundamentalValue tmp_dummy_value(true); 389 base::Value tmp_dummy_value(true);
390 value = &tmp_dummy_value; 390 value = &tmp_dummy_value;
391 ASSERT_FALSE(pref_value_store_->GetRecommendedValue( 391 ASSERT_FALSE(pref_value_store_->GetRecommendedValue(
392 prefs::kDefaultPref, 392 prefs::kDefaultPref,
393 base::Value::Type::STRING, &value)); 393 base::Value::Type::STRING, &value));
394 ASSERT_FALSE(value); 394 ASSERT_FALSE(value);
395 395
396 // Test getting a preference value that the |PrefValueStore| 396 // Test getting a preference value that the |PrefValueStore|
397 // does not contain. 397 // does not contain.
398 value = &tmp_dummy_value; 398 value = &tmp_dummy_value;
399 ASSERT_FALSE(pref_value_store_->GetRecommendedValue( 399 ASSERT_FALSE(pref_value_store_->GetRecommendedValue(
(...skipping 262 matching lines...) Expand 10 before | Expand all | Expand 10 after
662 prefs::kCommandLinePref)); 662 prefs::kCommandLinePref));
663 EXPECT_TRUE(pref_value_store_->PrefValueExtensionModifiable( 663 EXPECT_TRUE(pref_value_store_->PrefValueExtensionModifiable(
664 prefs::kUserPref)); 664 prefs::kUserPref));
665 EXPECT_TRUE(pref_value_store_->PrefValueExtensionModifiable( 665 EXPECT_TRUE(pref_value_store_->PrefValueExtensionModifiable(
666 prefs::kRecommendedPref)); 666 prefs::kRecommendedPref));
667 EXPECT_TRUE(pref_value_store_->PrefValueExtensionModifiable( 667 EXPECT_TRUE(pref_value_store_->PrefValueExtensionModifiable(
668 prefs::kDefaultPref)); 668 prefs::kDefaultPref));
669 EXPECT_TRUE(pref_value_store_->PrefValueExtensionModifiable( 669 EXPECT_TRUE(pref_value_store_->PrefValueExtensionModifiable(
670 prefs::kMissingPref)); 670 prefs::kMissingPref));
671 } 671 }
OLDNEW
« no previous file with comments | « components/prefs/pref_value_map_unittest.cc ('k') | components/prefs/testing_pref_store.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698