chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_connection_manager.cc - Issue 2666093002: Remove base::FundamentalValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_connection_manager.cc

Issue 2666093002: Remove base::FundamentalValue (Closed)

Patch Set: Rebase Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/downloads/downloads_api.cc ('k') | chrome/browser/extensions/api/extension_action/extension_action_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_connection_manager.cc

diff --git a/chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_connection_manager.cc b/chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_connection_manager.cc

index b6dd2d32a41bf9143b08d661b96f780e629cc310..e8a219c868a99f3128ceab20e3b661ed5cc9d8f7 100644

--- a/chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_connection_manager.cc

+++ b/chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_connection_manager.cc

@@ -178,7 +178,7 @@ void EasyUnlockPrivateConnectionManager::DispatchConnectionEvent(

std::unique_ptr<base::ListValue> args_copy(args->DeepCopy());

int connection_index = 0;

args_copy->Set(connection_index,

- base::MakeUnique<base::FundamentalValue>(connection_id));

+ base::MakeUnique<base::Value>(connection_id));

std::unique_ptr<Event> event(

new Event(histogram_value, event_name, std::move(args_copy)));

EventRouter::Get(browser_context_)