Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Unified Diff: chrome/browser/extensions/api/downloads/downloads_api.cc

Issue 2666093002: Remove base::FundamentalValue (Closed)
Patch Set: Rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/downloads/downloads_api.cc
diff --git a/chrome/browser/extensions/api/downloads/downloads_api.cc b/chrome/browser/extensions/api/downloads/downloads_api.cc
index 0f27c084dd22afe204206a490f69afd9f98a1b2c..c50afbbc1b8338ef7372e7753c88726318d55e95 100644
--- a/chrome/browser/extensions/api/downloads/downloads_api.cc
+++ b/chrome/browser/extensions/api/downloads/downloads_api.cc
@@ -1053,8 +1053,7 @@ void DownloadsDownloadFunction::OnStarted(
VLOG(1) << __func__ << " " << item << " " << interrupt_reason;
if (item) {
DCHECK_EQ(content::DOWNLOAD_INTERRUPT_REASON_NONE, interrupt_reason);
- SetResult(base::MakeUnique<base::FundamentalValue>(
- static_cast<int>(item->GetId())));
+ SetResult(base::MakeUnique<base::Value>(static_cast<int>(item->GetId())));
if (!creator_suggested_filename.empty() ||
(creator_conflict_action !=
downloads::FILENAME_CONFLICT_ACTION_UNIQUIFY)) {
@@ -1862,10 +1861,10 @@ void ExtensionDownloadsEventRouter::OnDownloadRemoved(
DCHECK_CURRENTLY_ON(BrowserThread::UI);
if (download_item->IsTemporary())
return;
- DispatchEvent(events::DOWNLOADS_ON_ERASED, downloads::OnErased::kEventName,
- true, Event::WillDispatchCallback(),
- base::MakeUnique<base::FundamentalValue>(
- static_cast<int>(download_item->GetId())));
+ DispatchEvent(
+ events::DOWNLOADS_ON_ERASED, downloads::OnErased::kEventName, true,
+ Event::WillDispatchCallback(),
+ base::MakeUnique<base::Value>(static_cast<int>(download_item->GetId())));
}
void ExtensionDownloadsEventRouter::DispatchEvent(

Powered by Google App Engine
This is Rietveld 408576698