Remove dynamic call from _LinkedHashSet. Remove some dcalls from the dart:html util library.

Remove dynamic call from _LinkedHashSet. Remove some dcalls from the dart:html util library.

BUG=
R=alanknight@google.com, vsm@google.com

Committed: https://github.com/dart-lang/sdk/commit/a8c7e74424c5d11ebbc7a42f80b9389ad27642d5

[Jacob, 2017-02-01 02:17:38]

jacobr@google.com changed reviewers:
+ vsm@google.com

[Jacob, 2017-02-01 02:17:39]

https://codereview.chromium.org/2666053004/diff/1/pkg/dev_compiler/tool/input...
File pkg/dev_compiler/tool/input_sdk/lib/html/html_common/conversions.dart
(right):

https://codereview.chromium.org/2666053004/diff/1/pkg/dev_compiler/tool/input...
pkg/dev_compiler/tool/input_sdk/lib/html/html_common/conversions.dart:238: List
l = JS('', '#', e);
This is a fairly frequently called helper so eliminating the dynamic calls in
its internals is probably worth it even though this code is a little ugly.

[Jacob, 2017-02-01 02:17:57]

Description was changed from

==========
Remove dynamic call from _LinkedHashSet. Remove some dcalls from the dart:html
util library.

BUG=
==========

to

==========
Remove dynamic call from _LinkedHashSet. Remove some dcalls from the dart:html
util library.

BUG=
==========

[Jacob, 2017-02-01 02:17:57]

jacobr@google.com changed reviewers:
+ alanknight@google.com

[vsm, 2017-02-01 18:37:14]

https://codereview.chromium.org/2666053004/diff/1/pkg/dev_compiler/tool/input...
File pkg/dev_compiler/tool/input_sdk/lib/html/html_common/conversions.dart
(right):

https://codereview.chromium.org/2666053004/diff/1/pkg/dev_compiler/tool/input...
pkg/dev_compiler/tool/input_sdk/lib/html/html_common/conversions.dart:130: List
copy = JS('List', '#', readSlot(slot));
var copy = JS('List', ...)

should get handled the right way I think, here and a couple places below - i.e.,
no cast + inference.

https://codereview.chromium.org/2666053004/diff/1/pkg/dev_compiler/tool/input...
File
pkg/dev_compiler/tool/input_sdk/lib/html/html_common/conversions_dart2js.dart
(right):

https://codereview.chromium.org/2666053004/diff/1/pkg/dev_compiler/tool/input...
pkg/dev_compiler/tool/input_sdk/lib/html/html_common/conversions_dart2js.dart:69:
action(key, JS('var', '#[#]', object, key));
Did this change anything?  action may still be a dcall I think.

[Jacob, 2017-02-01 20:33:49]

https://codereview.chromium.org/2666053004/diff/1/pkg/dev_compiler/tool/input...
File pkg/dev_compiler/tool/input_sdk/lib/html/html_common/conversions.dart
(right):

https://codereview.chromium.org/2666053004/diff/1/pkg/dev_compiler/tool/input...
pkg/dev_compiler/tool/input_sdk/lib/html/html_common/conversions.dart:130: List
copy = JS('List', '#', readSlot(slot));
On 2017/02/01 18:37:13, vsm wrote:
> var copy = JS('List', ...)
> 
> should get handled the right way I think, here and a couple places below -
i.e.,
> no cast + inference.

Done.

https://codereview.chromium.org/2666053004/diff/1/pkg/dev_compiler/tool/input...
File
pkg/dev_compiler/tool/input_sdk/lib/html/html_common/conversions_dart2js.dart
(right):

https://codereview.chromium.org/2666053004/diff/1/pkg/dev_compiler/tool/input...
pkg/dev_compiler/tool/input_sdk/lib/html/html_common/conversions_dart2js.dart:69:
action(key, JS('var', '#[#]', object, key));
On 2017/02/01 18:37:13, vsm wrote:
> Did this change anything?  action may still be a dcall I think.

action is not a dcall
because its signature
is 
(dynamic, dynamic) -> dynamic
The problem was action was previously type 
dynamic.

[Alan Knight, 2017-02-01 20:45:31]

lgtm

[vsm, 2017-02-01 20:59:43]

lgtm

https://codereview.chromium.org/2666053004/diff/20001/pkg/dev_compiler/tool/i...
File pkg/dev_compiler/tool/input_sdk/lib/html/html_common/conversions.dart
(right):

https://codereview.chromium.org/2666053004/diff/20001/pkg/dev_compiler/tool/i...
pkg/dev_compiler/tool/input_sdk/lib/html/html_common/conversions.dart:238: List
l = JS('', '#', e);
should be able to move the type to the right here too

[Jacob, 2017-02-01 21:26:45]

https://codereview.chromium.org/2666053004/diff/20001/pkg/dev_compiler/tool/i...
File pkg/dev_compiler/tool/input_sdk/lib/html/html_common/conversions.dart
(right):

https://codereview.chromium.org/2666053004/diff/20001/pkg/dev_compiler/tool/i...
pkg/dev_compiler/tool/input_sdk/lib/html/html_common/conversions.dart:238: List
l = JS('', '#', e);
On 2017/02/01 20:59:43, vsm wrote:
> should be able to move the type to the right here too

Done.

[Jacob, 2017-02-01 21:26:51]

Description was changed from

==========
Remove dynamic call from _LinkedHashSet. Remove some dcalls from the dart:html
util library.

BUG=
==========

to

==========
Remove dynamic call from _LinkedHashSet. Remove some dcalls from the dart:html
util library.

BUG=
R=alanknight@google.com, vsm@google.com

Committed:
https://github.com/dart-lang/sdk/commit/a8c7e74424c5d11ebbc7a42f80b9389ad27642d5
==========

[Jacob, 2017-02-01 21:26:52]

Committed patchset #3 (id:40001) manually as
a8c7e74424c5d11ebbc7a42f80b9389ad27642d5 (presubmit successful).