pkg/dev_compiler/tool/input_sdk/lib/html/html_common/conversions_dart2js.dart - Issue 2666053004: Remove dynamic call from _LinkedHashSet. Remove some dcalls from the dart:html util library.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/dev_compiler/tool/input_sdk/lib/html/html_common/conversions_dart2js.dart

Issue 2666053004: Remove dynamic call from _LinkedHashSet. Remove some dcalls from the dart:html util library. (Closed)

Patch Set: Remove dynamic call from _LinkedHashSet. Remove some dcalls from the dart:html util library. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/dev_compiler/tool/input_sdk/lib/html/html_common/conversions.dart ('k') | pkg/dev_compiler/tool/input_sdk/patch/collection_patch.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/dev_compiler/tool/input_sdk/lib/html/html_common/conversions_dart2js.dart

diff --git a/pkg/dev_compiler/tool/input_sdk/lib/html/html_common/conversions_dart2js.dart b/pkg/dev_compiler/tool/input_sdk/lib/html/html_common/conversions_dart2js.dart

index b5a1064554f66a1a3824700981c4e94a0a5cf06b..3cab3802cc09c358825f56c1437389af77933e79 100644

--- a/pkg/dev_compiler/tool/input_sdk/lib/html/html_common/conversions_dart2js.dart

+++ b/pkg/dev_compiler/tool/input_sdk/lib/html/html_common/conversions_dart2js.dart

@@ -60,11 +60,11 @@ class _StructuredCloneDart2Js extends _StructuredClone {

class _AcceptStructuredCloneDart2Js extends _AcceptStructuredClone {

- newJsList(length) => JS('JSExtendableArray', 'new Array(#)', length);

- newDartList(length) => newJsList(length);

- identicalInJs(a, b) => identical(a, b);

+ List newJsList(length) => JS('JSExtendableArray', 'new Array(#)', length);

+ List newDartList(length) => newJsList(length);

+ bool identicalInJs(a, b) => identical(a, b);

- void forEachJsField(object, action) {

+ void forEachJsField(object, action(key, value)) {

for (final key in JS('JSExtendableArray', 'Object.keys(#)', object)) {

action(key, JS('var', '#[#]', object, key));

}