Issue 266603002: Valgrind bot: always use tools/valgrind.supp

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 266603002: Valgrind bot: always use tools/valgrind.supp (Closed)

Created:
6 years, 7 months ago by borenet

Modified:
6 years, 7 months ago

Reviewers:
rmistry, mtklein, bsalomon, caryclark

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlesource.com/buildbot.git@master

Visibility:
Public.

More Reviews

Description

Valgrind bot: always use tools/valgrind.supp BUG=skia: Committed: https://skia.googlesource.com/buildbot/+/cc0b67143b361025ee95e6f03d9062b7e62df68b

Patch Set 1 #

Total comments: 1

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -12 lines)			Patch
	M	slave/skia_slave_scripts/flavor_utils/valgrind_build_step_utils.py	View		1 chunk	+1 line, -12 lines	1 comment	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

mtklein

lgtm https://codereview.chromium.org/266603002/diff/1/slave/skia_slave_scripts/flavor_utils/valgrind_build_step_utils.py File slave/skia_slave_scripts/flavor_utils/valgrind_build_step_utils.py (right): https://codereview.chromium.org/266603002/diff/1/slave/skia_slave_scripts/flavor_utils/valgrind_build_step_utils.py#newcode16 slave/skia_slave_scripts/flavor_utils/valgrind_build_step_utils.py:16: self._suppressions_file = os.path.join('tools', 'valgrind.supp') Wow, that's a pleasant ...

6 years, 7 months ago (2014-04-30 21:01:49 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/borenet@google.com/266603002/1

6 years, 7 months ago (2014-04-30 21:02:59 UTC) #4

commit-bot: I haz the power

6 years, 7 months ago (2014-04-30 21:03:04 UTC) #5

Message was sent while issue was closed.

Change committed as cc0b67143b361025ee95e6f03d9062b7e62df68b

Expand Messages | Collapse Messages