Valgrind bot: always use tools/valgrind.supp

slave/skia_slave_scripts/flavor_utils/valgrind_build_step_utils.py

Index: slave/skia_slave_scripts/flavor_utils/valgrind_build_step_utils.py
diff --git a/slave/skia_slave_scripts/flavor_utils/valgrind_build_step_utils.py b/slave/skia_slave_scripts/flavor_utils/valgrind_build_step_utils.py
index 0b2a72919f7ffc27a01d83dbba9821c3a831466e..85bb6818c0f568622365dcc700c1c92569cf3f01 100644
--- a/slave/skia_slave_scripts/flavor_utils/valgrind_build_step_utils.py
+++ b/slave/skia_slave_scripts/flavor_utils/valgrind_build_step_utils.py
@@ -13,18 +13,7 @@ import os
 class ValgrindBuildStepUtils(DefaultBuildStepUtils):
   def __init__(self, build_step_instance):
     DefaultBuildStepUtils.__init__(self, build_step_instance)
-    classname = self._step.__class__.__name__
-    if classname == 'RunTests':
-      self._suppressions_file = os.path.join('tests', 'valgrind.supp')
-    elif classname == 'RunGM':
-      self._suppressions_file = os.path.join('gm', 'valgrind.supp')
-    elif classname == 'RunBench':
-      self._suppressions_file = os.path.join('bench', 'valgrind.supp')
-    elif classname in ('RenderPictures', 'RenderPdfs', 'BenchPictures',
-                       'RunDecodingTests'):
-      self._suppressions_file = os.path.join('tools', 'valgrind.supp')
-    else:
-      self._suppressions_file = None
+    self._suppressions_file = os.path.join('tools', 'valgrind.supp')

[mtklein, 2014/04/30 21:01:49]

Wow, that's a pleasant change.

 
   def RunFlavoredCmd(self, app, args):
     """ Override this in new BuildStep flavors. """