Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(642)

Issue 2665993004: Use an OOPIF-compatible call chain when finding the top-level frame (Closed)

Created:
3 years, 10 months ago by estark
Modified:
3 years, 10 months ago
Reviewers:
dvadym, engedy, kolos1, nasko
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, jam, vabr+watchlistpasswordmanager_chromium.org, rouslan+autofill_chromium.org, rogerm+autofillwatch_chromium.org, sebsg+autofillwatch_chromium.org, browser-components-watch_chromium.org, mathp+autofillwatch_chromium.org, darin-cc_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org, gcasto+watchlist_chromium.org, elawrence
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use an OOPIF-compatible call chain when finding the top-level frame The ShowSuggestions autofill method must walk up the DOM hierarchy to determine the security origin of the top-level markup. Because the form may live in a different process than the top-level markup (due to out-of-process iframes), we must use a method call chain that works correctly across processes. This patch was written by elawrence@ in https://codereview.chromium.org/2660643002/. In this CL I'm TBRing it on his behalf. It's a small time-sensitive change (needs to be merged to M57) and was LGTMed by nasko@ and engedy@. mathp@, an OWNER, directed him to a password code owner who directed him to engedy@. BUG=685982 TBR=nasko@chromium.org,dvadym@chromium.org,kolos@chromium.org,engedy@chromium.org Review-Url: https://codereview.chromium.org/2665993004 Cr-Commit-Position: refs/heads/master@{#447307} Committed: https://chromium.googlesource.com/chromium/src/+/aaf3b71d6e6d9c1ce38fd741c0dbfdf28085fdf0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -6 lines) Patch
M components/autofill/content/renderer/password_autofill_agent.cc View 1 chunk +4 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
estark
3 years, 10 months ago (2017-01-31 18:41:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2665993004/1
3 years, 10 months ago (2017-01-31 18:42:37 UTC) #4
commit-bot: I haz the power
3 years, 10 months ago (2017-01-31 19:57:01 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/aaf3b71d6e6d9c1ce38fd741c0db...

Powered by Google App Engine
This is Rietveld 408576698