Chromium Code Reviews
DescriptionUse an OOPIF-compatible call chain when finding the top-level frame
The ShowSuggestions autofill method must walk up the DOM hierarchy to
determine the security origin of the top-level markup. Because the
form may live in a different process than the top-level markup (due to
out-of-process iframes), we must use a method call chain that works
correctly across processes.
This patch was written by elawrence@ in
https://codereview.chromium.org/2660643002/. In this CL I'm TBRing it on
his behalf. It's a small time-sensitive change (needs to be merged to
M57) and was LGTMed by nasko@ and engedy@. mathp@, an OWNER, directed him
to a password code owner who directed him to engedy@.
BUG=685982
TBR=nasko@chromium.org,dvadym@chromium.org,kolos@chromium.org,engedy@chromium.org
Review-Url: https://codereview.chromium.org/2665993004
Cr-Commit-Position: refs/heads/master@{#447307}
Committed: https://chromium.googlesource.com/chromium/src/+/aaf3b71d6e6d9c1ce38fd741c0dbfdf28085fdf0
Patch Set 1 #
Messages
Total messages: 7 (4 generated)
|
|||||||||||||||||||