Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Issue 2665983002: [runtime] Create macro for promise runtime functions (Closed)

Created:
3 years, 10 months ago by gsathya
Modified:
3 years, 10 months ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Create macro for promise runtime functions This groups together all the promise related runtime functions. BUG=v8:5343 Review-Url: https://codereview.chromium.org/2665983002 Cr-Commit-Position: refs/heads/master@{#42798} Committed: https://chromium.googlesource.com/v8/v8/+/93c65bbffb5f1bcf5a101969f47d7c23656fb10d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -13 lines) Patch
M src/runtime/runtime.h View 4 chunks +16 lines, -13 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
gsathya
FYI I don't want to alphasort the functions
3 years, 10 months ago (2017-01-31 00:24:05 UTC) #4
adamk
lgtm
3 years, 10 months ago (2017-01-31 00:32:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2665983002/1
3 years, 10 months ago (2017-01-31 01:20:29 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-01-31 01:22:36 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/93c65bbffb5f1bcf5a101969f47d7c23656...

Powered by Google App Engine
This is Rietveld 408576698