Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 2665973003: Fix peer addresses being reported raw rather than the actual address byte. (Closed)

Created:
3 years, 10 months ago by sortie
Modified:
3 years, 10 months ago
Reviewers:
rmacnak, kasperl
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix peer addresses being reported raw rather than the actual address byte. The struct sockaddr containing the remote address was being reported rather than the actual sin_addr / sin6_addr fields. Use the ToTypedData utility function to return the real address bytes as a dart list. Before this fix all remote addresses would be reported (on Linux) as 2.0.x.y where 2.0 means IPv4 and x.y are the remote port in big endian, i.e. the first four bytes of struct sockaddr. R=rmacnak@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/a8b549833389727af6643979148efadfaea100bf

Patch Set 1 #

Patch Set 2 : Add testcases #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -14 lines) Patch
M runtime/bin/socket.cc View 1 chunk +1 line, -4 lines 0 comments Download
M tests/standalone/io/socket_info_ipv4_test.dart View 1 1 chunk +5 lines, -5 lines 0 comments Download
M tests/standalone/io/socket_info_ipv6_test.dart View 1 1 chunk +7 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
sortie
3 years, 10 months ago (2017-01-31 13:40:59 UTC) #1
rmacnak
LGTM
3 years, 10 months ago (2017-01-31 17:27:21 UTC) #4
sortie
3 years, 10 months ago (2017-02-06 12:49:02 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
a8b549833389727af6643979148efadfaea100bf (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698