Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: tests/standalone/io/socket_info_ipv4_test.dart

Issue 2665973003: Fix peer addresses being reported raw rather than the actual address byte. (Closed)
Patch Set: Add testcases Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/socket.cc ('k') | tests/standalone/io/socket_info_ipv6_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/standalone/io/socket_info_ipv4_test.dart
diff --git a/tests/standalone/io/socket_info_ipv4_test.dart b/tests/standalone/io/socket_info_ipv4_test.dart
index f8d63bdd0a05e6840782a9fb8295ba44bba4e1a2..08baebcf03d83fbf663ebacbf34a5fdeb669cb56 100644
--- a/tests/standalone/io/socket_info_ipv4_test.dart
+++ b/tests/standalone/io/socket_info_ipv4_test.dart
@@ -7,18 +7,18 @@ import "dart:io";
void testHostAndPort() {
ServerSocket.bind("127.0.0.1", 0).then((server) {
-
Socket.connect("127.0.0.1", server.port).then((clientSocket) {
server.listen((socket) {
Expect.equals(socket.port, server.port);
Expect.equals(clientSocket.port, socket.remotePort);
Expect.equals(clientSocket.remotePort, socket.port);
Expect.equals(socket.remoteAddress.address, "127.0.0.1");
- Expect.equals(socket.remoteAddress.type,
- InternetAddressType.IP_V4);
+ Expect.equals(socket.remoteAddress.type, InternetAddressType.IP_V4);
+ Expect.listEquals(socket.remoteAddress.rawAddress, [127, 0, 0, 1]);
Expect.equals(clientSocket.remoteAddress.address, "127.0.0.1");
- Expect.equals(clientSocket.remoteAddress.type,
- InternetAddressType.IP_V4);
+ Expect.equals(
+ clientSocket.remoteAddress.type, InternetAddressType.IP_V4);
+ Expect.listEquals(clientSocket.remoteAddress.rawAddress, [127, 0, 0, 1]);
socket.destroy();
clientSocket.destroy();
server.close();
« no previous file with comments | « runtime/bin/socket.cc ('k') | tests/standalone/io/socket_info_ipv6_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698